Closed Bug 412906 Opened 17 years ago Closed 17 years ago

remove sha.c and sha.h from lib/freebl

Categories

(NSS :: Libraries, defect, P4)

Product:
NSS
Component:
Libraries
Version:
3.11.8
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: julien.pierre, Assigned: julien.pierre)

Details

Attachments

(1 file)

Remove dead code
7.38 KB, patch
nelson
: review+
Details | Diff | Splinter Review 
If I am not mistaken, this is dead code. Let's get rid of it. The real implementation is in sha_fast.c .
Attached patch Remove dead code — — Splinter Review 

        Attachment #297693 -
        Flags: review?(nelson)

    
  
Priority: -- → P3
Target Milestone: --- → 3.11.9
Version: 3.11.9 → 3.11.8
Severity: normal → trivial
Priority: P3 → P4

    
    

    
  
Comment on attachment 297693 [details] [diff] [review]
Remove dead code

There is a reference to sha.h in freebl/manifest.mn that must also 
be removed when sha.h is removed.

        Attachment #297693 -
        Flags: review?(nelson) → review+

    
    

    
  
Thanks, Nelson. I checked this in to the trunk.

Checking in manifest.mn;
/cvsroot/mozilla/security/nss/lib/freebl/manifest.mn,v  <--  manifest.mn
new revision: 1.52; previous revision: 1.51
done
Removing sha.c;
/cvsroot/mozilla/security/nss/lib/freebl/sha.c,v  <--  sha.c
new revision: delete; previous revision: 1.2
done
Removing sha.h;
/cvsroot/mozilla/security/nss/lib/freebl/sha.h,v  <--  sha.h
new revision: delete; previous revision: 1.2
done

Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: 3.11.9 → 3.12

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: