413294 - [gnomestripe] folders on bookmarks toolbar are missing icons

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Bug 404825 intentionally (after some debate, it seems) removed the folder icons from the bookmarks toolbar in Gnomestripe.  This causes a mix of icons and folders in the bookmarks toolbar to appear quite odd: the name of the folder runs in to the name of the icon for the previous item.  (The change introducing the dropdown arrows seems good to me, though.)

Steps to reproduce: Add some bookmarks and some folders to the bookmarks toolbar

Expected results: Visual appearance clearly distinguishing items, perhaps with additional user interface to indicate that more is available by clicking the folders.

Actual results: Folder preceded by non-folder is visually indistinct, and there is in general less clear a feeling that the toolbar contains a set of items.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: screenshot before bug (Linux nightly 2008-01-16-04-trunk)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: screenshot with bug (Linux nightly 2008-01-17-04-trunk)

Comment 3

[Bill Gianopoulos [:WG9s]]

(In reply to comment #0)
> runs in to the name of the icon for the previous item.  (The change introducing
> the dropdown arrows seems good to me, though.)

Except that there is now no visual continuity in the gnomestripe theme.  Why do these dropdown markers look completely different that the ones for the forward and back buttons?

Comment 4

[Bill Gianopoulos [:WG9s]]

BTW.  userChrome.css code to revert this is:

.bookmark-item[container] > .toolbarbutton-menu-dropmarker {
  display: none !important;
}

.bookmark-item[container] > .toolbarbutton-icon {
  display: -moz-box !important;
}

Comment 5

[Bill Gianopoulos [:WG9s]]

Or, you could install my new Gnomestripe Folder Icons extension from http://www.wg9s.com/mozilla/firefox/extensions .

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Ventnor: is there any reason you removed this? Linux parity? It's a pretty big change, and I'm not sure for the better in this case, since those things *are* bookmark folders.

Comment 7

[Michael Monreal [:micmon]]

I still like the change but feedback (bugzilla, irc, mozillazine forums) has generally been very negative, so it's probably the best to change it back before beta 3 if possible.

Comment 8

[u294409]

I think the folder and RSS icons should be restored. Linux is not Mac.

Comment 9

[Michael Monreal [:micmon]]

Jakub, that's strange to hear from you. I thought all you cared about was platform look and feel? The way it currently is is as native as it can be. ;)

Still, I agree that we should change back. Mostly because of livemarks (two different kinds of containers is something special in firefox) because I doubt anyone had considered this case.

Comment 10

[Michael Ventnor]

Attachment: Change back

Bring back icons, but keep the dropdown arrow.

Comment 11

[Michael Ventnor]

Comment on attachment 300127 [details] [diff] [review]
Change back

Really wanted for beta 3 since we're leaning back to use of icons rather than over-simplification.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 300127 [details] [diff] [review]
Change back

a=beltzner

Comment 13

[u294409]

Thanks Michael, I appreciate that restore :) .

Comment 14

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/browser/themes/gnomestripe/browser/browser.css 	1.161 

Comment 16

[Oliver Saier]

(In reply to comment #10)
> Created an attachment (id=300127) [details]
> Change back
> 
> Bring back icons, but keep the dropdown arrow.
> 

Well I'm not talking about "clutter" but the icon+arrow combo takes quite a lot of real estate in the bar. I thought the folder icon was intuitive enough to every Linux users as to what happens when they're clicked..