413500 - de German web services addition for Firefox 3

Status: VERIFIED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[Mic Berman]

Per Jan 7 google discussion, decided to add LEO as a new search plug in. Rationale is for specific search engine's this is a well used service for translating German to English (among other languages). It would be a good UE addition for German users

Comment 1

[Mic Berman]

waiting on permission from LEO directly and seach plug in to be built

Comment 2

[Kadir Topal [:atopal]]

Martin linked to the plugin in his mail, is this good to go? 

Comment 3

[Mic Berman]

good to go for me. received permission from Martin of Leo:


----- Original Message -----
From: "Martin Riethmayer" <[e-mail]>
To: [e-mail]
Cc: "a topal" <[e-mail]>, [e-mail], "Hans Riethmayer" <[e-mail]>
Sent: Tuesday, January 22, 2008 12:26:37 PM (GMT-0500) America/New_York
Subject: Re: [[e-mail]: Re: AW: Firefox 3 release]

Hi Mic
we would very much appreciate to be included in the upcoming German 
Firefox release as one of the pre-configured search engines. I will try 
to look into the OpenSearch documentation to make sure our current 
search engine file complies to it. I will send the final version ASAP.

Best regards

Martin

Comment 4

[Mic Berman]

received from LEO:

http://tdict.leo.org/plugins/Shared/Searches/leo_ende_de.xml (German
strings version)
http://tdict.leo.org/plugins/Shared/Searches/leo_ende_en.xml (English
strings version) 

Comment 5

[Mic Berman]

ping

Comment 6

[Hermann Schwab]

The fine thing about LEO is that it works both ways, en=>de and de=>en sametime, you don't need to specify which direction is preferred. A well working but undocumented .xpi for SEAMONKEY/Mozilla exists at 
http://leodict.mozdev.org/installation.html

I'm using the en<=>de extension in seamonkey, and en<=>de and fr<=>de s:

http://dict.leo.org/?lp=ende&lang=de&searchLoc=0&cmpType=relaxed&relink=on&sectHdr=on&spellToler=std&search=%s
http://dict.leo.org/frde?lp=frde&lang=de&searchLoc=0&cmpType=relaxed&relink=on&sectHdr=on&spellToler=on&search=%s

Sorry for the bugspam, I just wanted to show a very special usability advantage of LEO, besides its forums where you can talk or ask about things LEO doesn't yet/correctly/complete know.

more about bookmarklets: http://smoothwheel.mozdev.org/bookmarklets.html

Comment 7

[Mic Berman]

Abdulkadir - can you attach a patch or a diff to the bug so we can close please, thanks :)

Comment 8

[Kadir Topal [:atopal]]

Attachment: Adding leo to searchplugins

Comment 9

[Kadir Topal [:atopal]]

I'm not sure, is a review needed for this? If not, I'm going to check it in.

Comment 10

[Mic Berman]

review needed, yes, gavin is alerted he will review thanks

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 303223 [details] [diff] [review]
Adding leo to searchplugins

>Index: leo_ende_de.xml

>+<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/" xmlns:os="http://a9.com/-/spec/opensearch/1.1/">

Please remove the "os" namespace definition, and all "os:" prefixes, they aren't needed.

>+<os:ShortName>LEO De-Eng</os:ShortName>

When I visit http://dict.leo.org/ , the search bar advertises the engine with the name "LEO Eng-Deu". It would be good to stay consistent, so that the search bar doesn't offer to install an engine that's already installed. This is a problem with their current plugin, too - when you install it you still see an available engine to install, because the title attribute they use in the <link rel="search"> doesn't match the ShortName in the engine description file. Should probably point that out to them.

><os:InputEncoding>UTF-8</os:InputEncoding>

http://dict.leo.org/ seems to use ISO-8859-15, are you sure this is correct? I guess it matches their plugin, so it's probably OK.

>+<os:Url type="text/html" method="GET" template="http://dict.leo.org/?lp=ende&amp;search={searchTerms}">
>+</os:Url>

I guess they didn't request a specific Mozilla parameter? I'm not sure whether we include one by default usually or not. Mic?

>\ No newline at end of file

Please add one :)

Also need to add a SearchForm element (that just points to http://dict.leo.org/ , I guess - it's used for blank queries).

Comment 12

[Mic Berman]

AFAIK it's not a requirement but we usually ask if they want something like: from=fx3
I don't believe Martin (Leo) requested one but I will ask him if he'd like one and post response to the bug

Comment 13

[Mic Berman]

----- Original Message -----
From: "Martin Riethmayer"
To: "Michal Berman" 
Cc: "a topal" "Hans Riethmayer" 
Sent: Saturday, February 16, 2008 5:46:46 AM (GMT-0500) America/New_York
Subject: Re: Firefox 3 release]

Mic
the proposed solution (from=fx3) would be great, thanks.

Comment 14

[Kadir Topal [:atopal]]

Attachment: Next try for LEO-plugin

Comment 15

[Kadir Topal [:atopal]]

(In reply to comment #11)
> http://dict.leo.org/ seems to use ISO-8859-15, are you sure this is correct? I
> guess it matches their plugin, so it's probably OK.

I tried all German characters and it worked flawlessly, so I guess it's okay. 


> Also need to add a SearchForm element (that just points to http://dict.leo.org/
> , I guess - it's used for blank queries).

I don't know the spec at all, but the current form seems to handle blank queries quite well, forwarding to http://dict.leo.org/
How would another searchform element be added anyway?

Comment 16

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #15)
> > Also need to add a SearchForm element (that just points to http://dict.leo.org/
> > , I guess - it's used for blank queries).
> 
> I don't know the spec at all, but the current form seems to handle blank
> queries quite well, forwarding to http://dict.leo.org/
> How would another searchform element be added anyway?

Yeah, the search service code uses the <Url>'s host as a best-guess, but it would be better to be explicit. You just need to add "<SearchForm>http://dict.eo.org</SearchForm>" to the plugin.

Comment 17

[Kadir Topal [:atopal]]

Attachment: Leo plugin including seachform element

Alright, this should be it then.

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 303908 [details] [diff] [review]
Leo plugin including seachform element

>Index: leo_ende_de.xml

>+<Url type="text/html" method="GET" template="http://dict.leo.org/?lp=ende&amp;from=fx3&amp;search={searchTerms}">
>+</Url>

Just a nit: it would be easier to read if the parameters were in <Param> elements, e.g. http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/locales/en-US/searchplugins/google.xml&rev=1.13&mark=7-11 .

Comment 19

[Kadir Topal [:atopal]]

Attachment: Leo plugin including param elements

Checking in with seperate Param elements, thanks Gavin

Comment 20

[Axel Hecht [:Pike]]

Gavin, this didn't make it into the l10n-src-verification reference, right? Did that slip, or is that intentional?

Comment 21

[:Gavin Sharp [email: [e-mail]]]

Sorry, I forgot about this one. Just added it now.

Comment 22

[Mic Berman]

my only outstanding issue on this is whether we will include gmx as a mailto provider - please advise thanks

Comment 23

[Kadir Topal [:atopal]]

GMX is certainly one of the bigger mail providers here in Germany, including them would depend on how many providers we currently have and how many should be on the list as a maximum?

Comment 24

[Axel Hecht [:Pike]]

http://wiki.mozilla.org/Firefox_web_services_Review#de doesn't reference any real discussion on mail handlers, gmx.de is just one I knew about. Other recommendations?

We have two things on the plate here:

One is to get those providers to support protocol handlers on their site, the other is for us to decide which ones to support by default. We'll come up with limits today-ish, but that shouldn't keep us from reaching out to providers in Germany and lobby for supporting this. As they can add themselves as handlers on their site themselves, all their users would benefit from them supporting that, independent on whether we ship them or not.

http://developer.mozilla.org/en/docs/Web-based_protocol_handlers is the MDC documentation to point to.

Reopening to get traction that we still have things in the air here. CCing Jane, not sure if she could help in the communication here.

Comment 25

[Mic Berman]

comment #23, a maximum hasn't been determined yet. what's important is to have local choices to improve user exprience

Comment 26

[Kadir Topal [:atopal]]

then I would recommend web.de, gmx.de, gmail.com, hotmail.de and yahoo.de for Germany. That should cover the most popular free mail providers.

Comment 27

[Mic Berman]

moving the balance of this discussion on web handlers to a new bug so we can close this one out for RC1

Comment 28

[Axel Hecht [:Pike]]

Marking verified with yahoo and 30 boxes defaults in for protocol handlers, reference is http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/f0658577965d/reference/HEAD/de/.