Closed
Bug 413730
Opened 17 years ago
Closed 14 years ago
Replace all OBJ_GET_CLASS() macro calls with JSObject::getClass() calls
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: n.nethercote)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
94.23 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
Per bug 413045, comment #7, the cx argument is not needed for OBJ_GET_CLASS, OBJ_GET_PARENT, OBJ_GET_PROTO, and should therefore be removed. And the same is true for OBJ_GET_PRIVATE as well. This would signal to users that these macros don't do any thread synchronization etc.
|
Assignee | |
Comment 1•14 years ago
|
||
These are all gone except for OBJ_GET_CLASS. I'll get rid of that one.
Assignee: general → nnethercote
Blocks: 555429
|
|
Assignee | |
Updated•14 years ago
|
Summary: Remove cx argument from OBJ_GET_CLASS() macro n' friends. → Replace all OBJ_GET_CLASS() macro calls with JSObject::getClass() calls
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #437540 -
Flags: review?(gal)
|
||
Updated•14 years ago
|
Attachment #437540 -
Flags: review?(gal) → review+
|
||
Comment 3•14 years ago
|
||
That lightens the load! Thanks again, njn. /be
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/185ac309cea5
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/185ac309cea5
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•