414054 - Add explicit message if preference isn't set for about:crashes

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Dave Townsend [:mossop]]

From bug 411490, if the url pref isn't set then display an explicit message:

"Crash Report listing isn't configured in this application"

"The x.y preference needs to be set to the correct crash report
server for this application"

Are possibilities.

Comment 1

[Dave Townsend [:mossop]]

This will require a string and I'm not going to get to it till after the freeze

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This adds the explicit message if the preference isn't set:

"This application has not been configured to display crash reports. The preference breakpad.reportURL must be set."

Comment 3

[Asaf Romano (gone)]

Comment on attachment 299574 [details] [diff] [review]
patch rev 1

r=mano

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 299574 [details] [diff] [review]
patch rev 1

Seeking approval to land. This minor modification makes the about:crashes page behave sensibly on applications that aren't configured for it.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 299574 [details] [diff] [review]
patch rev 1

>>+<!ENTITY noConfig.label             "This application has not been configured to display crash reports. The preference <code>breakpad.reportURL</code> must be set.">

Without giving any indication of what to set it to, I don't think the latter half of this string is all that helpful and would recommend we drop it.

I'm also not very convinced we need this at all, but schrep's given his a, so feel free!

Comment 6

[Dave Townsend [:mossop]]

Landed as-is per bz's request.

Checking in toolkit/crashreporter/content/crashes.xhtml;
/cvsroot/mozilla/toolkit/crashreporter/content/crashes.xhtml,v  <--  crashes.xhtml
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/locales/en-US/crashreporter/crashes.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/crashreporter/crashes.dtd,v  <--  crashes.dtd
new revision: 1.2; previous revision: 1.1
done