414170 - "ASSERTION: row count did not change by the amount suggested, check caller"

Status: RESOLVED DUPLICATE of bug 479931

(Core :: XUL, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers:

###!!! ASSERTION: row count did not change by the amount suggested, check caller: 'rowCount == mRowCount', file /Users/jruderman/trunk/mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp, line 1817

WARNING: row count changed unexpectedly: 'mRowCount == rowCount', file /Users/jruderman/trunk/mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp, line 2764

###!!! ASSERTION: bad index: 'aIndex >= 0 && aIndex < mRows.Count()', file /Users/jruderman/trunk/mozilla/layout/xul/base/src/tree/src/nsTreeContentView.cpp, line 284

The "bad index" assertion is covered by bug 366203, but the "row count did not change by the amount suggested" assertion doesn't seem to be covered by other bug reports.

Comment 1

[[e-mail]]

Looks to me that ContentInserted needs to call InsertRowFor to deal with <option> correctly (it already does that for treeitem/treeseparator/optgroup).

Comment 2

[Jesse Ruderman]

Attachment: crash stack

The testcase crashes on trunk [@ nsTreeContentView::InsertRow].

Comment 3

[Jesse Ruderman]

Like bug 479931.

Comment 4

[[e-mail]]

This looks like a straight duplicate to me; the only difference I noticed is that there's a slightly different non-tree node in the tree. The crash would probably occur with a text node if you cared to give it a try.

Comment 5

[Timothy Nikkel (:tnikkel)]

Looks like a duplicate to me too. The patch in bug 479931 fixes this.

Comment 6

[Timothy Nikkel (:tnikkel)]

Added crashtest
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bb0cea0f629

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8bb0cea0f629