414344 - add Hungarian spelling dictionaries to the localized versions of Firefox and Thunderbird

Status: RESOLVED FIXED

(Mozilla Localizations :: hu / Hungarian, defect)

Description

[Németh László]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2

We need default spelling dictionaries in localized versions, too. There are MPLed spelling dictionaries for Hungarian, Polish, Arabic and so on.

Reproducible: Always

Steps to Reproduce:
1. Install a localized Hungarian Firefox 2 (unfortunately, there is no
localized 3 beta).

2. see languages menu item of text area context menu.
Actual Results:  
There is no Hungarian language in the language menu item of text are context menu.


Expected Results:  
There is default Hungarian spell checking in Hungarian versions of Mozilla
products, like in the American English version.

Comment 1

[Németh László]

First, we need to add the MPLed dictionaries to the Mozilla source.

Comment 2

[Németh László]

There are MPLed Hungarian dictionaries in the following Mozilla Add-on zip file:

http://downloads.sourceforge.net/magyarispell/hungarian_dictionary-1.1.4-fx%2Bzm%2Btb.xpi

Comment 3

[Németh László]

French localization has already had a solution for this problem:
https://bugzilla.mozilla.org/show_bug.cgi?id=408419

Axel, could you help us, too?

Comment 4

[Németh László]

I have relicensed the GPLed Hungarian MySpell dictionary to GPL/LGPL/MPL for Firefox 2.x integration, too. Links (the zipped Add-ons contains the dictionary files and their GPL/LGPL/MPL licences):

Firefox 2 (MySpell) dictionary: 
http://downloads.sourceforge.net/magyarispell/hungarian_dictionary-1.1.3.1-fx+zm+tb.xpi

Firefox 3 (Hunspell) dictionary:
http://downloads.sourceforge.net/magyarispell/hungarian_dictionary-1.1.4-fx+zm+tb.xpi

Comment 5

[Németh László]

András, can you change the status to "new"? Thanks.

Comment 6

[Andras Timar]

I confirm this bug. Axel, please take on this.

Comment 7

[Axel Hecht [:Pike]]

Ok, found a licensing comment that I can actually read on http://hunspell.sourceforge.net/ ;-)

I don't have to do anything here, Andras, you should check in the .aff and .dic, and potentially a README in l10n/hu/extensions/spellcheck/hunspell. The spellcheck directory is already on CVS, but empty, you can get it into your working copy by doing a
cvs update -d spellcheck
in l10n/hu/extensions, then create the hunspell dir and cvs add it, cvs add your dictionary files and readme, check-in with a comment referencing this bug. In this case that'd be good, as this has a licensing statement, so we have the link to that in cvs history.

That's all that's needed.

Comment 8

[Axel Hecht [:Pike]]

Just to be clear, don't check in the extension, but just the dictionary files.
It should look like http://mxr.mozilla.org/mozilla/source/extensions/spellcheck/locales/en-US/hunspell/, just that the dictionary files are likely called hu.aff or hu-HU.aff etc.

Comment 9

[Andras Timar]

Thanks for clear explanation, I'll check this in.

Comment 10

[Németh László]

Axel, many thanks for your help. András, we need two check in for MySpell and Hunspell, if it is possible. The xpi files contain the license and the dictionary files. Thanks for your work in advance.

Comment 11

[Axel Hecht [:Pike]]

Landing myspell would only matter for the 1.8 branch and Firefox 2.0.0.x. You'll need approval1.8.1.13 for that, .12 is just out of the door.

When requesting approval, it'd be good to see some testing on what happens when you already have an hungarian dictionary installed, and then get a build that has the dictionary shipped. Not sure if it's worth doing at this point in the 2.0.0.x lifecycle.

Comment 12

[Andras Timar]

I agree with Axel. Let's leave alone 2.0.0.x. Almost everyone will upgrade to version 3 within a few months.

Comment 13

[Németh László]

(In reply to comment #12)
> I agree with Axel. Let's leave alone 2.0.0.x. Almost everyone will upgrade to
> version 3 within a few months.
> 

Hunspell is better, but a lot of platform uses old Firefox versions, for example, the newest Firefox of my Fedora 6 is the version 1.5.0.12.
So newer Fedora etc. Linux versions will use Firefox 2 for a long time yet.
But I will be very glad of only the Firefox 3 integration, too.

Comment 14

[Andras Timar]

hu dictionary has been added to hu\extensions\spellcheck\hunspell\ and I keep it up to date.