Closed Bug 414797 Opened 17 years ago Closed 17 years ago

Fix click and hold code on Mac

Categories

(Firefox :: General, defect, P1)

Product:
Firefox
Component:
General
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3 beta3

People

(Reporter: Gavin, Assigned: asaf)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
4.70 KB, patch
Gavin
: review+
beltzner
: approval1.9b3+
beltzner
: approval1.9+
Details | Diff | Splinter Review 
Bug 404109 removed the back/forward buttons, so the code to enable "click and hold" behavior no longer works. We need to fix it.
Flags: blocking-firefox3?
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Target Milestone: --- → Firefox 3 beta4
Priority: P2 → P1
Target Milestone: Firefox 3 beta4 → Firefox 3 beta3
Keywords: regression
For mac, for now, hide dropmarker, re-enable click and hold such that it shows the new unified menu.

Kevin: bug 404109 enables the "keyhole", so if you could work on getting the appropriate styling hooked up in the CSS and file a patch with approval1.9b3? we can see if it makes sense to take it for beta 3
Attached patch patch — — Splinter Review 
Assignee: nobody → mano
Status: NEW → ASSIGNED

        Attachment #300423 -
        Flags: review?(gavin.sharp)

        Attachment #300423 -
        Flags: review?(gavin.sharp) → review+

    
  

        Attachment #300423 -
        Flags: approval1.9b3?

        Attachment #300423 -
        Flags: approval1.9?

    
    

    
  
Comment on attachment 300423 [details] [diff] [review]
patch

a=beltzner for 1.9 and beta 3

        Attachment #300423 -
        Flags: approval1.9b3?

        Attachment #300423 -
        Flags: approval1.9b3+

        Attachment #300423 -
        Flags: approval1.9?

        Attachment #300423 -
        Flags: approval1.9+

    
    

    
  
mozilla/browser/themes/pinstripe/browser/browser.css 1.120
mozilla/browser/base/content/browser.js 1.954
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020418 Firefox/3.0b3.  
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: