414982 - Use gcZeal setting in nsJSEnvironment, as we once did with WAY_TOO_MUCH_GC

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Brian Crowder]

As bz notes in bug 308429, I did not properly convert a WAY_TOO_MUCH_GC preprocessor guard in nsJSEnvironment to use the new runtime gcZeal parameter.  This patch does that.

It also fixes a warning I noticed while testing my change.

Comment 1

[Brian Crowder]

Attachment: patch, v1

Could've sworn I added this attachment the first time.  :(

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 300527 [details] [diff] [review]
patch, v1

Looks good.

Comment 3

[Brian Crowder]

Comment on attachment 300527 [details] [diff] [review]
patch, v1

Would be pretty harmless for b3, but I'll gladly settle for 1.9 approval and then I'll throw a checkin-needed on it.

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 300527 [details] [diff] [review]
patch, v1

This should go in for sure, and it could be useful in b3. It is safe.

/be

Comment 5

[Brian Crowder]

If someone has an opportunity to land this for me today, that would be great.  Thanks.

Comment 6

[Reed Loden [:reed]]

Checking in dom/src/base/nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.385; previous revision: 1.384
done

Comment 7

[Daniel Veditz [:dveditz]]

Probably wanted on the 1.8 branch

Comment 8

[Brian Crowder]

Should clear the wanted/blocking flags on these bugs, as they are replaced for the 1.8 branch by the rollup patch in bug 426628.