Closed Bug 415124 Opened 17 years ago Closed 17 years ago

add browser tests to qm-winxp02

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rcampbell, Unassigned)

References

Details

Attachments

(1 file)

Attached patch sisyphus winxp02Splinter Review
Add nightly browser tests to qm-winxp02
Attachment #300689 - Flags: review?(bclary)
Comment on attachment 300689 [details] [diff] [review]
sisyphus winxp02

>Index: master.cfg
>===================================================================
[snip]

>+windowsJS181BrowserOptFactory = factory.BuildFactory()
>+
>+windowsJS181BrowserOptFactory.addStep(CygwinBashShellCommand, name="Update Sisyphus",
>+                     workdir=SISYPHUS_BASE_WIN,
>+                     flunkOnFailure=False,
>+                     warnOnFailure=False,
>+                     command=["cvs", "update", "-d", "-P"],
>+                     env=MozillaEnvironments['windows'])
>+windowsJS181BrowserOptFactory.addStep(CygwinBashShellCommand, name="Update JS Tests",
>+                     workdir=SISYPHUS_BASE_WIN + "/tests/mozilla.org/js",

should be a DOS path? e.g. "\\test\\mozilla.org\\js". If we can get away with unixy like paths 
instead of the DOSy paths, I would vote for the unixy ones.

[snip]

>+windowsJS181BrowserDebugFactory = factory.BuildFactory()
>+
>+windowsJS181BrowserDebugFactory.addStep(CygwinBashShellCommand, name="Update Sisyphus",
>+                     workdir=SISYPHUS_BASE_WIN,
>+                     flunkOnFailure=False,
>+                     warnOnFailure=False,
>+                     command=["cvs", "update", "-d", "-P"],
>+                     env=MozillaEnvironments['windows'])
>+windowsJS181BrowserDebugFactory.addStep(CygwinBashShellCommand, name="Update JS Tests",
>+                     workdir=SISYPHUS_BASE_WIN + "/tests/mozilla.org/js",

should be a DOS path? 

[snip]

r+ with those nits picked.
Attachment #300689 - Flags: review?(bclary) → review+
whups. fixing...
Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/sisyphus/master.cfg,v  <--  master.cfg
new revision: 1.9; previous revision: 1.8
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Mass move of Core:Testing bugs to mozilla.org:ReleaseEngineering. Filter on RelEngMassMove to ignore.
Component: Testing → Release Engineering
Product: Core → mozilla.org
QA Contact: testing → release
Version: Trunk → other
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: