415923 - Multiple keyboard shortcuts busted (eg switch tab, undo close tab)

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008020604 Minefield/3.0b4pre

In the nightly, cmd-<digit> doesn't switch tab - it just beeps. If the location bar is focused then it works.

Similarly, cmd-shift-t doesn't undo a closed tab, and cmd-shift-r doesn't completely reload a page.

This appeared between the hourly builds which started at 2223 and 2255 PST, so the regression window is
  http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1202278980&maxdate=1202280899

Perhaps bug 358379 ?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Steps to reproduce cmd-<digit>:

1, Make a new profile with 2255 or later build (result: loads two tabs)
2, cmd-2 (beep! no tab switch)
3, focus the location bar
4, cmd-1 or cmd-2 (switches tab)
5, switch to blank tab, then click on content area
6, cmd-1 (beep! no tab switch)

cmd-shift-t and cmd-shift-r also work when the location bar is focused.

Comment 6

[Dan Ray]

I'm having problems with cmd+[num] and cmd+shift+r, but cmd+shift+t works for me.

Comment 8

[Joe Shaw]

(In reply to comment #0)
> In the nightly, cmd-<digit> doesn't switch tab - it just beeps. If the location
> bar is focused then it works.

It also works if you give the search box, the actual notebook tab, or the status bar focus.  So it seems like it's broken if the page content (or any widget on it, like this bugzilla text box) has focus.

Comment 10

[Josh Aas]

backed out 358379

Comment 12

[MordEth]

This appears to have suffered regression in the latest nightly build.

Comment 13

[MordEth]

(In reply to comment #12)
> This appears to have suffered regression in the latest nightly build.

Apparently I was mistaken; it seems that in the process of updating, something was written to my prefs.js that caused Cmd+<1-9> to stop working.  (I've no clue what, exactly; all of the differences between it and the copy on my desktop do not seem to be indicative of something that would cause this.)  Replacing my prefs.js fixed it.