415963 - [1.1] Implement XPath number functions: power, random, and compare

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Merle Sterling]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008020507 Minefield/3.0b4pre

We need to implement the XPath number functions power(), random(), and compare() for XForms 1.1.



Reproducible: Always

Comment 1

[Merle Sterling]

Attachment: testcase: power()

Comment 2

[Merle Sterling]

Attachment: testcase: random()

Comment 3

[Merle Sterling]

Attachment: testcase: compare()

Comment 4

[Merle Sterling]

Attachment: patch

Comment 5

[aaronr]

Comment on attachment 301711 [details] [diff] [review]
patch

>Index: nsXFormsXPathFunctions.cpp
>===================================================================

>+NS_IMETHODIMP
>+nsXFormsXPathFunctions::Random(PRBool aSeed, double *aResult)
>+{
>+    if (aSeed) {
>+      // initialize random seed.
>+      srand (0);

You can use PR_GetRandomNoise to come up with a seed to use instead of using 0 all the time.

With that, r=me

Comment 6

[Merle Sterling]

(In reply to comment #5)
> (From update of attachment 301711 [details] [diff] [review])
> >Index: nsXFormsXPathFunctions.cpp
> >===================================================================
> >+NS_IMETHODIMP
> >+nsXFormsXPathFunctions::Random(PRBool aSeed, double *aResult)
> >+{
> >+    if (aSeed) {
> >+      // initialize random seed.
> >+      srand (0);
> You can use PR_GetRandomNoise to come up with a seed to use instead of using 0
> all the time.
> With that, r=me

That should have been srand(time(NULL)) but I'll use PR_GetRandomNoise.

Comment 7

[Merle Sterling]

Attachment: patch2

Merging with the latest version of the file on the trunk; using PR_GetRandomNoise to generate a seed.

Comment 8

[aaronr]

checked into trunk for msterlin.  Now we need the 1.8 branch version of the patch.

Comment 9

[Merle Sterling]

Attachment: patch for 1.8 branch

Comment 10

[aaronr]

Comment on attachment 302917 [details] [diff] [review]
patch for 1.8 branch

Jonas, can you please review so that we can get approval to put it into 1.8?  Thanks.

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 302917 [details] [diff] [review]
patch for 1.8 branch

>+      double result = 0;
>+      if (string1.Length() > string2.Length()) {
>+        result = 1;
>+      } else if (string1.Length() < string2.Length()) {
>+        result = -1;
>+      } else {
>+        result = strcmp(NS_ConvertUTF16toUTF8(string1).get(),
>+                        NS_ConvertUTF16toUTF8(string2).get());
>+      }

This looks wrong. Is "z" < "aa" really right? Spec says lexicographic comparison.

sr=me with that fixed or checked.

Comment 12

[Merle Sterling]

Attachment: patch2 for 1.8 branch

Removing length check for compare().

Comment 13

[aaronr]

Comment on attachment 303416 [details] [diff] [review]
patch2 for 1.8 branch

Asking for approval for 1.8 branch.  This code is reachable only by xforms xpath evaluators which should only ever be instantiated by the xforms extension.  This should have no impact on any other xpath user.

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 303416 [details] [diff] [review]
patch2 for 1.8 branch

Seems a little odd to be adding features to the branch -- xforms users will now have to require a specific minimum version.

approved for 1.8.1.13, a=dveditz for release-drivers

Comment 15

[aaronr]

Attachment: patch checked into 1.8

patch checked into 1.8.  Same code as previous patch, just updated to the branch.

Comment 16

[aaronr]

checked into 1.8 branch for msterlin