416015 - Done button on star UI shouldn't be enabled until something has changed

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008020614 Minefield/3.0b4pre ID:2008020614

1. New profile, start Firefox
2. Go to a site that isn't bookmarked already, so the star is white
3. Click on the star twice so it's gold and the UI comes up.

The Cancel button and the Done button are both enabled, even tho there's no reason why the Done button should be clickable, so the Done button should be greyed out to start with.

Only after the user has changed something in the star UI, eg: the name changed, the location of the bookmark changed, a tag added or removed, should the Done button be clickable.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Outside of the lengthy debate over making these types of dialogs instant apply, in general OK buttons don't enable only after things have changed (although Apply buttons do on windows).  The Done button was meant as a bit of a UI concession to users expecting the Ok/Cancel model, so switching to the Apply behavior would probably make things worse, especially since I don't know of any Apply/Cancel dialogs, usually the order is Ok/Cancel/Apply.  I recommend wontfix.

Comment 2

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 3

[Mark Banner (:standard8)]

The dialog is now just Done / Remove Bookmark. It is an instant-apply dialog. Given there is no cancel, I think it is reasonable for Done to be enabled straight away.