416047 - Test 1 fails in compiling Bugzilla::Install::CPAN and install-module.pl when Cygwin is installed

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Marc Schumann [:Wurblzap]]

The testing suite's test 1 reports compilation of Bugzilla/Install/CPAN.pm to fail. In turn, this makes install-module.pl seem to fail test 1. It seems to me this is because CPAN.pm gives some output on startup ("Set up gcc environment - 3.4.4 (cygming special, gdc 0.12, using dmd 0.125)"), which probably confuses the testing harness.

Compilation for Bugzilla/Install/CPAN.pm and install-module.pl succeeds, so test 1 should report this correctly.

This may be a Windows-only issue.

Comment 1

[Max Kanat-Alexander]

Ah, the testing suite shouldn't be trying to compile anything in the lib/ directory, that's the problem. So we need to stop it from doing that.

Comment 2

[Marc Schumann [:Wurblzap]]

This is not about the lib/ directory, but about Bugzilla/Install/CPAN.pm (or its dependence CPAN.pm, which emits said output when "use"d in Bugzilla/Install/CPAN.pm).

Comment 3

[Max Kanat-Alexander]

Ohhh, thank you. What version of CPAN.pm are you using?

Comment 4

[Marc Schumann [:Wurblzap]]

I'm using version 1.9205.

Comment 5

[Frédéric Buclin]

I cannot reproduce the problem, neither on windows.bugzilla.org nor on my local Windows installation. Wurblzap says on IRC this may be related to Cygwin, despite I don't see how they could interact. Not a blocker IMO.

Comment 6

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 7

[Frédéric Buclin]

Comment on attachment 310254 [details] [diff] [review]
Patch

>+        if ($^O =~ /MSWin32/i
>+            && grep($_ eq $file, 'install-module.pl',
>+                                 'Bugzilla/Install/CPAN.pm')
>+           ) {

Nit: the indentation could be:

>+        if ($^O =~ /MSWin32/i
>+            && grep($_ eq $file, 'install-module.pl', 'Bugzilla/Install/CPAN.pm'))
>+        {

which is clearer IMO. r=LpSolit

Comment 8

[Marc Schumann [:Wurblzap]]

Hrm, the line exceeds 80 characters now. Oh well.

Checking in t/001compile.t;
/cvsroot/mozilla/webtools/bugzilla/t/001compile.t,v  <--  001compile.t
new revision: 1.17; previous revision: 1.16
done