416053 - KDE/Gnome startup notification not disappearing when app window is up

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Robert Kaiser]

For probably as long as I can remember using 1.9 trunk builds (I guess some time around the switch of SeaMonkey to toolkit), the KDE startup notification (jumping app icon next to the mouse) does not disappear when the (first) app window is open, it only goes way after some timeout. This looks like the desktop never realizes our window is actually up.
Interestingly, this has been working on branch, where we AFAIK don't specifically support the freedesktop startup notification stuff.

Comment 1

[Patrice T]

I had the same problem:

You need to compile Firefox with the startup-notification library.
(--enable-startup-notification)

Voilà! fixed ;)
Bye.

Comment 2

[Stroker]

Why are the binary releases not being compiled with --enable-startup-notification?

This is a problem due to some distro's simply repacking the Mozilla release binaries, e.g., Slackware.

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

Probably that bug could be morphed as apparently startup notification on Linux is broken with Gecko 1.9.1. At least I see it non working with FF3.5 in Gnome and KDE even when built with --enable-startup-notification.

What do other people see?

Comment 4

[Robert Kaiser]

I never saw it working at least with 1.9.1 on KDE 3.x or 4.x, but I never tried GNOME, all on openSUSE Factory and stable 11.x releases and all with self-compiled builds which have --enable-startup-notification.

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

It worked with Firefox 3 but not FF3.5.

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch f(rom Lubos Lunak)

Patch from Lubos Lunak from downstream bug:
https://bugzilla.novell.com/show_bug.cgi?id=518603

"
The patch fixes it - 'toolkit' was NULL at the old place, only created by the
call to 'CreateHiddenWindow'. I guess the patch is safe and correct.
"

Comment 8

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/mozilla-central/rev/1a9b6d37e99a

Comment 9

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 405030 [details] [diff] [review]
patch f(rom Lubos Lunak)

Pretty low risk for 1.9.2 and solves an annoying visual behaviour on Linux desktops

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 405030 [details] [diff] [review]
patch f(rom Lubos Lunak)

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.

Comment 11

[Ginn Chen]

I filed Bug 534845, for distros build firefox with --enable-startup-notification, you may also want to get it fixed.

Comment 12

[Robert Kaiser]

If this is not being looked at for 1.9.2 right now just for logistical purposes, can we request for it to go straight into 1.9.1 so our current releases work well with KDE?

Comment 13

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 405030 [details] [diff] [review]
patch f(rom Lubos Lunak)

requesting approval for next possible release.
(cannot cancel the original one for some reason)

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 405030 [details] [diff] [review]
patch f(rom Lubos Lunak)

a=beltzner for 1.9.2.4

Comment 15

[Wolfgang Rosenauer [:wolfiR]]

mozilla-1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/965a31dcde02

Comment 16

[Ginn Chen]

You need to fix Bug 534845 on 1.9.2 branch to make restart situation work.