416115 - session restore busted after 393716 checkin

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[aja+bugzilla]

Things messed up for me first build after patch for bug 393716 got checked in.

Basically, tabs that were okay when you shutdown/restart never load upon startup.
Even with a brand new sessionstore.js, I'm only getting the first and last restored tabs to load....the rest just sit there with throbbers and "Loading..."

Following two messages are showing up in console2 error log:

Error: aEntry is undefined
Source file: file:///D:/Program%20Files/Minefield/firefox/components/nsSessionStore.js
Line: 1609

Error: aEntry is undefined
Source file: file:///D:/Program%20Files/Minefield/firefox/components/nsSessionStore.js
Line: 1193

Comment 1

[aja+bugzilla]

Lines 1608 & 1609:
    var ioService = Cc["@mozilla.org/network/io-service;1"].
                    getService(Ci.nsIIOService);

Line 1193:
    function extractHosts(aEntry) {

Comment 2

[Steve England [:stevee]]

1. New profile, start firefox
2. Turn session restore on
3. Surf to some tabs, like www.neowin.net www.shacknews.com www.doom9.org
4. Close Firefox, and start it up again

Works: 20080207_0035_firefox-3.0b4pre.en-US.win32
Broken: 20080207_0142_firefox-3.0b4pre.en-US.win32

Checkins to module PhoenixTinderbox between 2008-02-07 00:35 and 2008-02-07 01:41 :
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1202373300&maxdate=1202377319

Comment 3

[aja+bugzilla]

(In reply to comment #2)
> 1. New profile, start firefox
> 2. Turn session restore on
> 3. Surf to some tabs, like www.neowin.net www.shacknews.com www.doom9.org
> 4. Close Firefox, and start it up again
> 
> Works: 20080207_0035_firefox-3.0b4pre.en-US.win32
> Broken: 20080207_0142_firefox-3.0b4pre.en-US.win32
> 
> Checkins to module PhoenixTinderbox between 2008-02-07 00:35 and 2008-02-07
> 01:41 :
> http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1202373300&maxdate=1202377319
> 

I concur with the above steps to repro, works/broken builds, and regression range. (he's quicker than I am sometimes :)

Comment 4

[Simon Bünzli]

Note to self: This only happens on pages containing (i)frames. Investigating...

Comment 5

[aja+bugzilla]

(In reply to comment #4)
> Note to self: This only happens on pages containing (i)frames. Investigating...
> 
Could well be....tinderbox waterfall page is one I normally have open.

Comment 6

[Simon Bünzli]

Attachment: fix embarassing typo

Turns out that I've misplaced one parenthesis. Sorry for that!

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 301898 [details] [diff] [review]
fix embarassing typo

ouch. apologies for missing that in the initial review!

Comment 8

[Reed Loden [:reed]]

I just landed this without approval since it's a one character bustage/typo fix.

Checking in browser/components/sessionstore/src/nsSessionStore.js;
/cvsroot/mozilla/browser/components/sessionstore/src/nsSessionStore.js,v  <--  nsSessionStore.js
new revision: 1.96; previous revision: 1.95
done

I'll go respin nightlies now.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 301898 [details] [diff] [review]
fix embarassing typo

This is now a blocker and doesn't need it, but I loves me my session restore, so a=beltzner for good measure!

Comment 10

[Tim Riley [:timr]]

I am getting this problem also.  Including with the 8am build.  (Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008020708 Minefield/3.0b4pre)

STR: 
1) close minefield
2) restart minefield
3) see all tabs saying "Loading..." with throbber spinning.

Error Console:

Error: Warning: unrecognized command line flag -foreground
Source File: file:///Users/timr/Desktop/Firefox%20installations/FF3Nightly-20071211/Minefield.app/Contents/MacOS/components/nsBrowserContentHandler.js
Line: 660

Error: aEntry is undefined
Source File: file:///Users/timr/Desktop/Firefox%20installations/FF3Nightly-20071211/Minefield.app/Contents/MacOS/components/nsSessionStore.js
Line: 1609

Error: aEntry is undefined
Source File: file:///Users/timr/Desktop/Firefox%20installations/FF3Nightly-20071211/Minefield.app/Contents/MacOS/components/nsSessionStore.js
Line: 1193

New tabs open properly.

Comment 11

[Simon Bünzli]

(In reply to comment #10)
> I am getting this problem also.  Including with the 8am build.

Once you've used a broken build, you have to delete the corrupted sessionstore.js from your profile to get things working again.

Comment 12

[Tony Chung [:tchung]]

stevee, can you still repro this?  if not, we can mark this bug verified.

Comment 13

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022711 Minefield/3.0b4pre ID:2008022711
-->VERIFIED