Closed Bug 416329 Opened 16 years ago Closed 16 years ago

Correct Ria Klaassen's name in "Credits"

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3 beta4

People

(Reporter: stephend, Assigned: Gavin)

References

(
URL
)

Details

(Keywords: verified1.8.1.13)

Attachments

(1 file)

patch
683 bytes, patch
dveditz
: approval1.8.1.13+
Details | Diff | Splinter Review 
I'm surprised she hasn't already asked for it to be corrected, but Ria Klaassen's name is misspelled in About Minefield's "Credits" section (button).

It was added (incorrectly) in https://bugzilla.mozilla.org/show_bug.cgi?id=331660#c30.

In addition, can whomever's spinning up this trivial patch also include her in about:credits?  She has been, and continues to be, an amazing contributor.

Thanks!
I just went ahead and fixed this.
mozilla/browser/base/content/credits.xhtml 	1.34

You'll need to email credits@mozilla.org (Gerv) if you want to be added to about:credits. See instructions at the bottom of http://www.mozilla.org/credits/ .
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Summary: Correct Ria Klaassen's name in "Credits" and add it to about:credits? → Correct Ria Klaassen's name in "Credits"
Target Milestone: --- → Firefox 3 beta4
Attached patch patch — — Splinter Review 
Assignee: nobody → gavin.sharp
Status: RESOLVED → ASSIGNED

        Attachment #302508 -
        Flags: approval1.8.1.13?
Resolution: FIXED → ---
Status: ASSIGNED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED

    
    

    
  
(In reply to comment #1)
> I just went ahead and fixed this.
> mozilla/browser/base/content/credits.xhtml      1.34
> 
> You'll need to email credits@mozilla.org (Gerv) if you want to be added to
> about:credits. See instructions at the bottom of
> http://www.mozilla.org/credits/ .

Yeah, I'll let her do that; thanks for fixing this.

    
    

    
  
Thanks Stephen and Gavin.

    
    

    
  
Verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008021104 Minefield/3.0b4pre
Status: RESOLVED → VERIFIED

    
    

    
  
Comment on attachment 302508 [details] [diff] [review]
patch

approved for 1.8.1.13, a=dveditz for release-drivers

        Attachment #302508 -
        Flags: approval1.8.1.13? → approval1.8.1.13+

    
    

    
  
mozilla/browser/base/content/credits.xhtml 	1.10.4.18 
Keywords: fixed1.8.1.13

    
    

    
  
verified fixed for 1.8.1.13 using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13 ID:2008031114
Keywords: fixed1.8.1.13 → verified1.8.1.13

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: