Closed
Bug 416549
Opened 16 years ago
Closed 16 years ago
MathML does not render properly with text-align:justify
Categories
(Core :: MathML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta5
People
(Reporter: fredw, Assigned: fredw)
References
()
Details
(Keywords: regression)
Attachments
(5 files, 1 obsolete file)
35.09 KB,
application/xml
|
Details | |
1.04 KB,
patch
|
karlt
:
review+
roc
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
7.21 KB,
application/xml
|
Details | |
7.15 KB,
application/xml
|
Details | |
3.10 KB,
application/xml
|
Details |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1.11) Gecko/20071128 Iceweasel/2.0.0.11 (Debian-2.0.0.11-1) Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1.11) Gecko/20071128 Iceweasel/2.0.0.11 (Debian-2.0.0.11-1) If MathML is inside a XHTML element with the property text-align:justify, then the property is also applied to the MathML elements that are consequently displayed strangely. I do not know what the specifications say, but I do not think such a behaviour is expected. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Updated•16 years ago
|
Component: General → MathML
Product: Firefox → Core
QA Contact: general → mathml
Assignee | ||
Comment 1•16 years ago
|
||
This is of course for the CVS version of Firefox, as it works well with Firefox 2.
Updated•16 years ago
|
Version: unspecified → Trunk
Assignee | ||
Comment 2•16 years ago
|
||
Actually, It seems it isn't related to the "justify" property. Firefox simply does not compute well the spaces inside a formula.
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
Comment 3•16 years ago
|
||
We shouldn't have all the extra space between elements. We'd didn't with FF2.
Assignee | ||
Comment 4•16 years ago
|
||
I've just looked again to the bug, finally it is due to the CSS property: p {text-indent: 2em} I'll add an attachment to show this.
Assignee | ||
Comment 5•16 years ago
|
||
Should be fixable by setting text-indent:0 on the mathml anonymous block in mathml.css.
Assignee | ||
Comment 7•16 years ago
|
||
The suggestion above works for me. Here is a patch.
Comment 8•16 years ago
|
||
Comment on attachment 305579 [details] [diff] [review] Patch that add text-indent:0 Thanks. We should just add a space after the colon for consistency with the other properties.
Attachment #305579 -
Flags: superreview?(roc)
Attachment #305579 -
Flags: review+
Comment on attachment 305579 [details] [diff] [review] Patch that add text-indent:0 You might want to consider setting some extra stuff here. Maybe text-align, for example. But this patch is good for now.
Attachment #305579 -
Flags: superreview?(roc) → superreview+
Flags: wanted1.9+
Flags: blocking1.9?
Flags: blocking1.9-
Comment 10•16 years ago
|
||
Comment on attachment 305579 [details] [diff] [review] Patch that add text-indent:0 not much risk in this style change.
Attachment #305579 -
Flags: approval1.9?
Assignee | ||
Comment 11•16 years ago
|
||
I made some test with margin, padding, border and text-align. None of these properties produce spaces (see margin_padding_border_text-align.xml) so I suppose only text-indent have to be set to zero in mathml.css
Assignee | ||
Comment 12•16 years ago
|
||
But I found another bug with text-align (see text-align_right.xml). The third equality have its right side out of the screen whereas it is not the case for the two first. I suppose it is because of the mtable, whose width is considered as zero.
Updated•16 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 13•16 years ago
|
||
Comment on attachment 305579 [details] [diff] [review] Patch that add text-indent:0 a1.9+=damons
Attachment #305579 -
Flags: approval1.9? → approval1.9+
Comment 14•16 years ago
|
||
(In reply to comment #12) > I suppose it is because of the mtable, whose width is considered as zero. Yes, I think so. Let's check that when bug 363240 is fixed.
Comment 15•16 years ago
|
||
Frédéric, do you have a cvs account? (If not, I can check this fix in.)
Assignee | ||
Comment 16•16 years ago
|
||
(In reply to comment #15) > Frédéric, do you have a cvs account? > (If not, I can check this fix in.) > No I don't. I would appreciate if you can check in for me.
Updated•16 years ago
|
Assignee: nobody → fwsmail35
Comment 17•16 years ago
|
||
Checked in: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1204840685&maxdate=1204840793&who=karlt%2B%25karlt.net
Status: NEW → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5
Comment 18•16 years ago
|
||
karlt backed out the patch to fix an orange.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 19•16 years ago
|
||
Checked in again and no orange. http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1204861562&maxdate=1204861642&who=karlt%2B%25karlt.net
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Flags: in-testsuite?
Assignee | ||
Updated•16 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: MathML does not render properly with text-align:justify → MathML does not render properly with text-align:indent
Assignee | ||
Comment 20•16 years ago
|
||
Assignee | ||
Comment 21•16 years ago
|
||
Attachment #337272 -
Attachment is obsolete: true
Comment 22•16 years ago
|
||
Frédéric, please file a new bug report for that. Reopening old FIXED bugs just causes confusion. You can mention the new bug number here.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Summary: MathML does not render properly with text-align:indent → MathML does not render properly with text-align:justify
Assignee | ||
Comment 23•16 years ago
|
||
Here is the new bug number: https://bugzilla.mozilla.org/show_bug.cgi?id=454085 Also, I submit a patch.
You need to log in
before you can comment on or make changes to this bug.
Description
•