Closed
Bug 416700
Opened 16 years ago
Closed 16 years ago
0 or 0% leaks results in bloatdiff dying
Categories
(Webtools Graveyard :: Tinderbox, defect)
Webtools Graveyard
Tinderbox
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
|
1014 bytes,
patch
|
coop
:
review+
|
Details | Diff | Splinter Review |
Bug 409284 added overly aggressive error checking to bloatdiff, which causes it to bail if there are no leaks (or if the percent leaks is 0 due to roundoff). Firefox is green only because build-seamonkey-util.pl ignores bloatdiff's failure to run.
Attachment #302425 -
Flags: review?(ccooper)
|
Assignee | |
Updated•16 years ago
|
Assignee: build → ajschult
|
||
Comment 1•16 years ago
|
||
Comment on attachment 302425 [details] [diff] [review] patch Can you add a comment in the code as to why we don't check leaked or leakPercent? It will make it easier for the next person who has to touch this code. r+ with that.
Attachment #302425 -
Flags: review?(ccooper) → review+
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Component: Tinderbox Configuration → Tinderbox
Product: mozilla.org → Webtools
|
||
Updated•10 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•