417143 - Duplicate entries to add same search engine

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[nathaniel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

After viewing the source, it appears that adding two entries for the same search engine on a page (for 'discovering the engine') using <link rel="search" type="application/opensearchdescription+xml"> will cause duplicate entries to appear in the add search engine drop-down menu.
Firefox should detect that they are the same, and only show one entry. (Confusing otherwise.)


Reproducible: Always

Steps to Reproduce:
1.Make sure Mozilla Links search is not installed
2.Visit http://mozillalinks.org/wp/2008/02/a-deep-look-to-firefox-3-beta-3/
3.Click search drop-down to see search engines available
Actual Results:  
Notice two entries for same url. (Same title, and hover text shows same url)

Expected Results:  
One engine (if really the same) or some indicator that they are actually different.

The referenced site has:
<link rel="search" type="application/opensearchdescription+xml" title="Mozilla Links" href="http://www.mozillalinks.org/download/mozillalinks.xml">


<link rel="search" type="application/opensearchdescription+xml" title="Mozilla Links" href="http://www.mozillalinks.org/download/mozillalinks.xml">

As the code that produces teh duplicate entries. Note that both entries are exactly the same.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I considered last-wins behavior rather than first-wins, but this is a bit of an edge case, and first-wins seemed simpler. Also removes a check that will never be true, as far as I can tell.

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 303054 [details] [diff] [review]
patch

Yeah, I agree that this is edge-casey enough that first vs. last shouldn't really matter.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: with test

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 303167 [details] [diff] [review]
with test

a=beltzner

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/base/content/browser.js 	1.966
mozilla/browser/base/content/test/browser_autodiscovery.js 	1.2