Closed Bug 417175 Opened 16 years ago Closed 16 years ago

The proto theme doesn't lighten the color of toolbars when windows backgrounded

Categories

(Firefox :: Shell Integration, enhancement)

x86
macOS
enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 406730

People

(Reporter: blassey, Assigned: blassey)

Details

Attachments

(2 files, 1 obsolete file)

Native windows lighten in color when ever they are not the top most window.  Because firefox with the proto theme does not, users can be confused as to which window has focus.
Attachment #302999 - Flags: review?(mconnor)
Attachment #302999 - Flags: approval1.9?
This patch is changing colors (and image) based on focus and blur events.  It would probably be better if there was an event specific to the window being sent to the background and foreground.  Does that exist?
Status: NEW → ASSIGNED
Attachment #302999 - Flags: review?(mconnor)
Attachment #302999 - Flags: review?(mano)
Attachment #302999 - Flags: approval1.9?
Comment on attachment 302999 [details] [diff] [review]
changes the color on focus

This shouldn't be done on the theme level (there is an ancient bug about disallowing setting attributes like this on theme bindings).

I think the right way to fix this is to first 
move the binding to browser/base/content (and apply it from pinstripe), then also use  real <handler> elements for this.
Attachment #302999 - Flags: review?(mano) → review-
I think we're in the process of uncrippling themes, we made an explicit choice to stop trying to preserve some sort of "safe" theme framework a while back, but I don't know if we've explicitly declared as such, but this patch should be acceptable now.
Apologies, I just realized there was a second change to browser.css.  Without it, things probably look funny.

Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: