Closed Bug 417877 Opened 16 years ago Closed 16 years ago

Stop using nsIPref in MainController

Categories

(Camino Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.6

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Details

(Keywords: fixed1.8.1.13)

Attachments

(1 file, 1 obsolete file)

Attached patch fix (obsolete) — Splinter Review
For some reason we have a direct use of the Gecko pref service in MainController; we should be using the Cocoa wrapper.
Attachment #303669 - Flags: superreview?(mark)
Attached patch v2Splinter Review
Actually, while I'm at it, there's a unless forward declaration of nsIPrefBranch in KeychainServices.h that should be axed as well.
Attachment #303669 - Attachment is obsolete: true
Attachment #303671 - Flags: superreview?(mark)
Attachment #303669 - Flags: superreview?(mark)
Attachment #303671 - Flags: superreview?(mark) → superreview?(mikepinkerton)
Comment on attachment 303671 [details] [diff] [review]
v2

sr=pink
Attachment #303671 - Flags: superreview?(mikepinkerton) → superreview+
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: fixed1.8.1.13
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: