417903 - nsStackWalker crash when _SymGetLineFromAddr64 fails

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

SymGetModuleInfoEspecial64 has no way to indicate when _SymGetLineFromAddr64 fails. When _SymGetLineFromAddr64 fails, lineInfo in NS_DescribeCodeAddress is uninitialized and we crash in PL_strncpyz(aDetails->filename, lineInfo.FileName, sizeof(aDetails->filename)).

I hit this doing refcount logging on Windows. My fix is just to zero out aLineInfo if SymGetModuleInfoEspecial64 fails, and checking lineInfo.FileName for null before we use the line number data.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 303697 [details] [diff] [review]
fix

Simple fix to prevent a crash during stack walking. I don't think we actually do any stack walking in release builds so this is pretty safe...

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 303697 [details] [diff] [review]
fix

oops ... Simple fix to prevent a crash during stack walking. I don't think we actually
do any stack walking in release builds so this is pretty safe...

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 303697 [details] [diff] [review]
fix

a=beltzner for 1.9

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in