418649 - layout insepctor build bustage when building on windows mobile

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

ERROR is defined when building on windows mobile. This cases a build busted when building layout/inspector because inISearchObserver.idl redefines ERROR.

Patch prefixes these constants with

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 304515 [details] [diff] [review]
patch v.1

r=dbaron

Does Firebug or something depend on this?  We don't actually seem to use it in our own codebase.

Comment 2

[Doug Turner (:dougt)]

i didn't find anything in our tree and searching around on google didn't find consumers (just copies of the inISearchObserver idl).  Do you think we should also change the UUID?

Comment 3

[Doug Turner (:dougt)]

dbaron said no to my question on IRC.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 304515 [details] [diff] [review]
patch v.1

a=beltzner for 1.9

Comment 5

[Doug Turner (:dougt)]

Checking in layout/inspector/public/inISearchObserver.idl;
/cvsroot/mozilla/layout/inspector/public/inISearchObserver.idl,v  <--  inISearchObserver.idl
new revision: 1.8; previous revision: 1.7
done
Checking in layout/inspector/src/inCSSValueSearch.cpp;
/cvsroot/mozilla/layout/inspector/src/inCSSValueSearch.cpp,v  <--  inCSSValueSearch.cpp
new revision: 1.27; previous revision: 1.26
done