418791 - Don't try to discard image data when the image is animating

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect, P2)

Description

[Alfred Kayser]

Attachment: V1: Don't start the timer when image is animating

The 'Discard image' function of imgContainer creates a timer (with 45 seconds delay) to discard image data. However, when the image is animating, this timer is cancelled and re-created for every frame that is accessed in the animation.
This is probably the cause of the crash of bug 399925.

A simple solution is to not set the timer when the image is animating (as the discard will never happen). This prevents needless creation and cancellations of the timer, and saves CPU and memory.

A more drastic solution is not to save the discard data for such images, but that is something for another bug.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Marking P2 for now, stuart please change priority based on review -- this might need to be P1 if there could be regressions from the change.

Comment 2

[Reed Loden [:reed]]

Checking in modules/libpr0n/src/imgContainer.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v  <--  imgContainer.cpp
new revision: 1.67; previous revision: 1.66
done