419350 - [ia64] build failure using gcc 4.3

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch contributed by Doug Chapman

From https://bugzilla.redhat.com/show_bug.cgi?id=434608

With the latest gcc4.3 iostream.h is replaced with just iostream.  There is some
ia64 specific code in xulrunner that still uses iostream.h.

The file is:
mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_ipf64.cpp

I am attaching a patch that fixes this issue.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 305399 [details] [diff] [review]
Patch contributed by Doug Chapman

r=caillon

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It doesn't look like it's used, and it certainly shouldn't be.  Why not just remove the #include entirely?  And maybe fix xptcinvoke_ipf32.cpp while you're there?  (That might need the stdint.h include, though, if iostream in turn includes stdint.)

Comment 3

[Doug Chapman]

David,

I tried another build with #include <iostream> removed and you are correct, it builds just fine on ia64.

- Doug

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 305399 [details] [diff] [review]
Patch contributed by Doug Chapman

a=beltzner for 1.9

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Committed with the removal of the line as suggested by dbaron.

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Doug, can you see about the ipf32 code mentioned in comment 2?

Comment 7

[Doug Chapman]

(In reply to comment #6)
> Doug, can you see about the ipf32 code mentioned in comment 2?
> 

yes, i see it but my eyes must have glossed over it before since i didn't notice the ipf32 bit part.  I can give that a try but honestly I am not sure how to get it to build.  The ia64 archetecture doesn't have a 32bit mode, it can run x86 32 bit binaries with an emulator but that would be just the full 32bit package.

I will look into this file, might be obsolete from the days when we did have a 32bit mode for the older Itanium systems.  We might want to just remove it.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 305399 [details] [diff] [review]
Patch contributed by Doug Chapman

branch checkins get used by lots of people who look at the bugs rather than bonsai -- please attach a patch that reflects what's going to be checked in. a-

If I've misunderstood comment 5 and this really is the patch then you can re-request.

Comment 9

[Doug Chapman]

Attachment: updated patch

Sorry, should have posted this after I tested it.  Here is the updated patch which  just removes #include <iostream.h> as we have determined that it wasn't needed anyway.

Comment 10

[Doug Chapman]

For those curious....

I looked at xptcinvoke_ipf32.cpp as suggested.  This file is used by HP-UX only so I wouldn't suggest changing anything on it.  If we were to make the same changes on it was are just as likely to break HP-UX and I don't have a copy of HP-UX to test it on.

Comment 11

[Daniel Veditz [:dveditz]]

Comment on attachment 306066 [details] [diff] [review]
updated patch

approved for 1.8.1.13, a=dveditz for release-drivers

Comment 12

[Samuel Sidler (old account; do not CC)]

Comment on attachment 306066 [details] [diff] [review]
updated patch

This hasn't landed yet and we're at code freeze. We'll re-approve it for 1.8.1.14 when we open the tree up for checkins again.

Comment 13

[Samuel Sidler (old account; do not CC)]

Comment on attachment 306066 [details] [diff] [review]
updated patch

Approved for 1.8.1.14. a=ss for release-drivers.

Comment 14

[Raúl Porcel]

Uh...why this isn't commited to 1.8?

Comment 15

[Reed Loden [:reed]]

Fixed on trunk == RESOLVED FIXED.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Checked in on the 1.8 branch:
mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_ipf64.cpp 	1.2.28.1