419866 - "Recent Tags" list in smart bookmarks no longer seems to be working

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

Not sure when it started failing but must have been recently.  I added a new bookmark with a unique tag this morning (with every intention of using "Recent Tags" to find it again later) and it doesn't show up in the Recent Tags list.

Comment 1

[Marcia Knous [:marcia]]

dria: Please post the Build ID you are using or seeing this on when you report bugs. We have seen bugs specific to 10.4 or 10.5 on occasion, so this especially helpful when you are running on mac.  Thanks.

Comment 2

[Ondrej Brablc]

Does restart help? May be there is an issue with refreshing. Does the query display anything else or is it empty?

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

Not working in Vista HP either with today's build.  
Also appears that adding a new Bookmark is not being added to Smart Bookmarks either. 

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre Firefox/3.0 ID:2008022704

Comment 4

[Deb Richardson [:dria] (plz NEEDINFO)]

Sorry, I almost always make sure i'm up to date before filing.  Current build ID is Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4pre) Gecko/2008022704 Minefield/3.0b4pre.

Restarting doesn't help.

Comment 5

[Ondrej Brablc]

I can confirm this. Something wrong with limiting to 10 recent tags (bug 385245). It is visible in Places Library. When you click in left pane on "Smart Bookmarks" you can then on right pane change maxResults of the place uri to 12 or some bigger number, the tag shows up in this case.

Tagging seems to work fine, so I'm lovering the severity to normal, but will deliver patch today or tomorrow.

Comment 6

[Ondrej Brablc]

Attachment: Allow sorting by date for tags query

History queries for sidebar and for recent tags are special queries that return list of other queries. They are all QUERY_TYPE_HISTORY. However, for this type of query it is not possible to sort by date fields (dateAdded and lastModified).

However, RESULTS_AS_TAG_QUERY is based on bookmarks rather than history and date fields are available. Changing the queryType to QUERY_TYPE_BOOKMARKS is not possible due to other implications, so the change in this patch allows sorting by date for this type explicitly.

There is one line in the patch which fixes wrong line ending. I hope it is not necessary to create a separate bug for this.

Comment 7

[Ondrej Brablc]

Attachment: Sort by lastModified rather than dateAdded

Dietrich noted, that we should sort rather by lastModified than dateAdded (which was used already before bug 385245 to excuse myself ;-).

NIGHTLY USERS ATTENTION PLEASE!!!

Please follow these steps to fix the URI of the "Recent Tags" to sort correctly, no automatic fix is included in this patch for you.

1) Open menu Bookmarks->Show All Bookmarks
2) Locate "Smart Bookmarks" folder and click on it in the left pane.
3) Click on "Recent Tags" on right side.
4) In the lower pane change in location sort=12 to sort=14.

Thanks.

Comment 8

[Dietrich Ayala (:dietrich)]

Comment on attachment 306077 [details] [diff] [review]
Sort by lastModified rather than dateAdded

r=me, thanks.

drivers: minor change that fixes a regression from a P1 B4 blocker.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306077 [details] [diff] [review]
Sort by lastModified rather than dateAdded

a1.9b4=beltzner

Comment 10

[Reed Loden [:reed]]

Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.265; previous revision: 1.264
done
Checking in browser/base/content/browser-places.js;
/cvsroot/mozilla/browser/base/content/browser-places.js,v  <--  browser-places.js
new revision: 1.100; previous revision: 1.99
done
Checking in browser/components/nsBrowserGlue.js;
/cvsroot/mozilla/browser/components/nsBrowserGlue.js,v  <--  nsBrowserGlue.js
new revision: 1.60; previous revision: 1.59
done

Comment 11

[Jim Jeffery not reading bug-mail 1/2/11]

In comment #7 above: 
1) Open menu Bookmarks->Show All Bookmarks
2) Locate "Smart Bookmarks" folder and click on it in the left pane.
3) Click on "Recent Tags" on right side.
4) In the lower pane change in location sort=12 to sort=14.

I don't understand what to do with step 4) I don't see anything in that pane that relates to location.  
I see Name & Description text boxes...

Can you please clarify ?

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022802 Minefield/3.0b4pre Firefox/3.0 ID:2008022802

Comment 12

[Ondrej Brablc]

(In reply to comment #11)
> I don't understand what to do with step 4) I don't see anything in that pane
> that relates to location.  
> I see Name & Description text boxes...
> 
> Can you please clarify ?

Could it be that you have clicked in point 3 on the left pane rather than on the right pane?

Comment 13

[Jim Jeffery not reading bug-mail 1/2/11]

I don't know how, but perhaps by Smart Bookmarks folder was corrupt, I toggled the pref "browser.places.createdSmartBookmarks" and it created a new folder that seems to be working and I was able to edit the location as per instructions. 

thanks

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry that I have to reopen this bug but it isn't completely fixed. At least running the build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022806 Minefield/3.0b4pre ID:2008022806 doesn't show up the new added tag under Smart Bookmarks of the Bookmarks Toolbar. Within the Library the tag is listed under Recent tags. 

Comment 15

[Ondrej Brablc]

(In reply to comment #14)
> Sorry that I have to reopen this bug but it isn't completely fixed. At least
> running the build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre)
> Gecko/2008022806 Minefield/3.0b4pre ID:2008022806 doesn't show up the new added
> tag under Smart Bookmarks of the Bookmarks Toolbar. Within the Library the tag
> is listed under Recent tags. 
> 

This is the same query and I believe, that after restart you will see it on the toolbar too. I have created a new bug 420261 for the refreshing problem.

Comment 16

[Asaf Romano (gone)]

Er, isn't sorting by lastModified show tags from which item were removed as recent? Why is dateAdded not working?

Comment 17

[Ondrej Brablc]

dateAdded is the time, when the tag container has been created. So adding new links to the tag would not change it. lastModified is really modified on removal too, so if you would remove tag from the bookmark and there will still be something marked with this tag, the tag would show as most recent (someone could consider this ok).

May be the best would be to use max(dateAdded) of the items having the tag.

SELECT null, 'place:type=%ld&queryType=%d&sort=%ld&folder=' || f.id, 
       f.title, null, null, null, null, null, null, 
       max(i.dateAdded), max(i.lastModified)
FROM   moz_bookmarks f JOIN moz_bookmarks i ON f.id = i.parent
WHERE  f.parent = %ld
GROUP BY f.id

There is a little problem, that we would need two queries one with max and the other with min.

Comment 18

[Tracy Walker [:tracy]]

verified with: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre)
Gecko/2008032106 Minefield/3.0b5pre
and
Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9b5pre)
Gecko/2008032104 Minefield/3.0b5pre

Comment 19

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv