419951 - Toggle "Page Info" with its keyboard shortcut (like "Downloads" does)

Status: NEW

(Firefox :: Page Info Window, enhancement)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008022713 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4pre) Gecko/2008022713 Minefield/3.0b4pre

<Ctrl> + I should toggle Page Info, just like <Ctrl> + Y toggles
Downloads window.

Reproducible: Always

Steps to Reproduce:
1. Open the Page Info window with <Ctrl> + I (keep <Ctrl> pressed after the window appeared)
2. Press I.
Actual Results:  
The Page Info window does not disappear.


Expected Results:  
The Page Info window should disappear, just like Downloads windows disappears when
doing the same steps (with different key bindings).

Comment 1

[Andrés Delfino]

The following report makes the bug platform independent:

Page Info keyboard shortcut should toggle Page Info, just like
Downloads window keyboard shortcut toggles Download window.

Reproducible: Always

Steps to Reproduce:

1. Open the Page Info window with its shortcut (which varies from platform) (keep
modifier keys (Alt/Alt Gr/Ctrl/Shift/etc...) pressed after the window appeared,
but don't press the letter you have to press along them)

2. Press the letter you used along the modifier keys.

Actual Results:  
The Page Info window does not disappear.

Expected Results:  
The Page Info window should disappear, just like Downloads windows disappears when doing the same steps (but with its own key binding).

Comment 2

[Pranav Ravichandran [:pranavrc]]

Attachment: Proposed patch

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 586764 [details] [diff] [review]
Proposed patch

Ctrl+I doesn't open Page Info on Windows, so it shouldn't close it either.

On Windows, Ctrl+I opens the Bookmarks sidebar. That's a rather silly IE compatibility thing. Maybe we can drop that. Do other browsers support this on Windows?

Comment 4

[Philip Chee]

1. SeaMonkey uses CTRL-I to open the page info window on Windows.
2. Does MSIE9 still have a bookmarks sidebar? (note I haven't used MSIE since, uh, I forget).

Comment 5

[Pranav Ravichandran [:pranavrc]]

IE9 still has the Favorites sidebar with the Ctrl+i shortcut. There appears to be no keyboard  shortcut for the pageInfo dialog on Windows.

Comment 6

[Pranav Ravichandran [:pranavrc]]

Any decision on this yet? Should this be made Unix-specific?

Comment 7

[Dão Gottwald [:dao]]

You can try to redefine Ctrl+I on Windows and request ui-review from [e-mail].

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this still the case, or is there a Windows keyboard shortcut working now?

Comment 9

[KLB]

Ctrl+I still opens bookmarks sidebar. I didn't find any obvious keyboard shortcut to open page info. Could be nice for someone.  Not sure why this was never flagged as "New" from "Unconfirmed".