Closed Bug 420154 Opened 16 years ago Closed 16 years ago

Print finer-grained leak info in runtests.py than just pass/fail and a table

Categories

(Testing :: Mochitest, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
It'd be nice for the individual classes that leak to be printed as errors (and when the leak threshold isn't exceeded, to note the leaks in the log but not cause failure).

I tested this patch using bug 420152 with large and small leak thresholds sufficient to trigger both the error-fail and warning branches.
Attachment #306344 - Flags: review?(sayrer)
I'm pretty sure leak logging will fail (catastrophically) in builds without refcount logging, because the leak file wouldn't be created.  This patch moves the file into the profile directory (to avoid staleness concerns) and prints a warning if the file isn't created when leak logging is enabled (which indicates that refcount logging is disabled).
Attachment #306344 - Attachment is obsolete: true
Attachment #306404 - Flags: review?(sayrer)
Attachment #306344 - Flags: review?(sayrer)
Attachment #306404 - Flags: review?(sayrer) → review+
Fixt.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
MochitestMassMove -- plz ignore.
Component: Testing → Mochitest
Product: Core → Testing
Target Milestone: mozilla1.9beta4 → mozilla1.9
QA Contact: testing → mochitest
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: