420242 - Huge height with "width: -moz-max-content", "margin: 100%;", table

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

The testcase lays out with ridiculously large width and height, triggering several assertions.

Comment 1

[Jesse Ruderman]

Still happens on trunk.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Looks like the various assertions this testcase caused were downgraded to warnings now.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Landing the testcase but leaving the bug open since the warning is still being hit.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb3eab4dd38c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fb3eab4dd38c

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 8

[Daniel Holbert [:dholbert]]

"leave-open" was just here because we landed a testcase but no fix.

Having said that, though, it seems this is now WORKSFORME. I can load the testcase without any assertions/warnings being spammed and without any huge content.

I tested the attached testcase, as well as the in-tree version from comment 4, which is available here:
https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tables/crashtests/420242-1.xhtml

I'm using a 64-bit linux debug build. (Note: this bug technically has the platform field set to macOS, but I don't think it matters -- I suspect that's just where it was reported from, and there shouldn't be anything mac-specific about the layout code involved here. So I'm fine having tested on linux.)

--> WFM

Comment 9

[Daniel Holbert [:dholbert]]

Nightly fix range (determined by loading the attached testcase and looking for scrollbars to indicate huge content per comment 0):
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=10ea10d9993c9701e5525928257a589dea2c05d8&tochange=35c7be9c2db288d1d449e3cc586c4164d642c5fd

In that range, I would bet this was fixed by bug 1338108 (which is about arithmetic involving a zero width, which makes sense because margin:100% in the testcase probably leaves us with a zero width here).