420618 - Improve nsAbDirectoryDataSource and nsSubscribeDataSource ArcLabelsOut functions

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Following on from dwitte's comment in bug 406198, and also the realisation now that we can pre-set an nsCOMArray's size (maybe not on the stack, but at least set it in one go), I think it would be better to change the ArcLabelsOut functions of nsAbDirectoryDataSource and nsSubscribeDataSource to use nsCOMArray rather than nsIMutableArray.

Patch attached.

Comment 1

[[e-mail]]

Comment on attachment 306913 [details] [diff] [review]
The fix

I don't know how long we intend to keep these datasources ;-)

>+    nsCOMArray<nsIRDFResource> array(hasChildren ? 5 : 6);
This is the wrong way around ;-) but I'd just allocate 6 all the time anyway.

Comment 2

[Mark Banner (:standard8)]

Checked in -> fixed.