42079 - compile errors in /mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect, P3)

Description

[David R. Linn]

From Bugzilla Helper:
User-Agent: Mozilla/4.73 [en] (X11; U; SunOS 5.7 sun4u; Nav)
BuildID:    build from 2000-06-09 source tarball

When building mozilla from source tarball 2000-06-09, on a Sun Ultra5 with
Solaris 7, Sun Workshop C v5.0, and gmake v3.76.1, I get the output below:

CC -library=iostream -o nsGtkMozRemoteHelper.o -c -DOSTYPE=\"SunOS5\" -DOJI
-D_IMPL_NS_WIDGET -DUSE_XIM -D_TIME_H=1  -I../../../dist/include
-I../../../../mozilla/include    
-I../../../../mozilla/widget/src/gtk/../xpwidgets
-I../../../../mozilla/widget/src/gtk  -I/usr/openwin/include   -KPIC  -mt -O 
-DDEBUG -DDEBUG_drl -DTRACING -g -I/opt/pkgs/GTKgtk/v1.2.8/include
-I/opt/pkgs/GTKglib/v1.2.8/lib/glib/include -I/opt/pkgs/GTKglib/v1.2.8/include
-I/usr/openwin/include -DMOZILLA_CLIENT -DBROKEN_QSORT=1
-DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DULTRA_SPARC=1 -DD_INO=d_ino
-DMOZ_WIDGET_GTK=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\" -DSTDC_HEADERS=1
-DHAVE_ST_BLKSIZE=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1
-DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1 -DHAVE_DIRENT_H=1
-DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_SYS_FILIO_H=1 -DHAVE_SYS_IPC_H=1 -DHAVE_SYS_SHM_H=1
-DHAVE_X11_EXTENSIONS_XSHM_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_SYS_MOUNT_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1
-DHAVE_LIBRESOLV=1 -DHAVE_LIBSOCKET=1 -DHAVE_LIBNSL=1 -DHAVE_LIBELF=1
-DHAVE_LIBINTL=1 -DHAVE_LIBPOSIX4=1 -DHAVE_LIBW=1 -D_REENTRANT=1 -DHAVE_RANDOM=1
-DHAVE_QSORT=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STATVFS=1 -DHAVE_MEMMOVE=1
-DHAVE_USLEEP=1 -DHAVE_GETTIMEOFDAY=1 -DGETTIMEOFDAY_TWO_ARGS=1
-DHAVE_DEV_ZERO=1 -DHAVE_IOS_BINARY=1 -DHAVE_OSTREAM=1 -DHAVE_CPP_EXPLICIT=1
-DHAVE_CPP_SPECIALIZATION=1 -DHAVE_CPP_MODERN_SPECIALIZE_TEMPLATE_SYNTAX=1
-DHAVE_CPP_ACCESS_CHANGING_USING=1 -DHAVE_CPP_AMBIGUITY_RESOLVING_USING=1
-DHAVE_CPP_NEW_CASTS=1 -DNEED_CPP_UNUSED_IMPLEMENTATIONS=1
-DHAVE_CPP_TROUBLE_COMPARING_TO_ZERO=1 -DHAVE_I18N_LC_MESSAGES=1
-DMOZ_MAIL_NEWS=1 -DNS_MT_SUPPORTED=1 -DUSE_SHM=1 -DMOZ_LOG_REFCNT=1
-DDETECT_WEBSHELL_LEAKS=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_MATHML=1
-DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1
-DLAYERS=1  ../../../../mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp
"../../../dist/include/nsHashtable.h", line 128: Error: Cannot use void* to
initialize nsISupports**.
"../../../dist/include/nsHashtable.h", line 130: Error: Cannot use void* to
initialize nsISupports**.
"../../../../mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp", line 58: Warning:
String literal converted to char* in initialization.
"../../../../mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp", line 60: Warning:
String literal converted to char* in initialization.
"../../../../mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp", line 61: Warning:
String literal converted to char* in initialization.
"../../../../mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp", line 62: Warning:
String literal converted to char* in initialization.
"../../../../mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp", line 65: Warning:
String literal converted to char* in initialization.
"../../../../mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp", line 131: Error:
Cannot use void* to initialize char*.
"../../../../mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp", line 143:
Warning: String literal converted to char* in assignment.
"../../../../mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp", line 500: Error:
Cannot return void* from a function that should return char*.
"../../../../mozilla/widget/src/gtk/nsGtkMozRemoteHelper.cpp", line 540: Error:
Cannot use void* to initialize nsCAutoString.
5 Error(s) and 6 Warning(s) detected.
gmake[3]: *** [nsGtkMozRemoteHelper.o] Error 5
gmake[3]: Leaving directory `/ufs/sys/sys3/mozilla/src/09/s7/widget/src/gtk'
gmake[2]: *** [install] Error 2
gmake[2]: Leaving directory `/ufs/sys/sys3/mozilla/src/09/s7/widget/src'
gmake[1]: *** [install] Error 2
gmake[1]: Leaving directory `/ufs/sys/sys3/mozilla/src/09/s7/widget'
gmake: *** [install] Error 2

The underlying problem seems to be that NULL seems to have become a void *.  I'm
guessing that this definition is coming from GLIB v1.2's glib.h which provides a

#define	NULL	((void *) 0)

as a fallback value  (bracketed within #ifndef/#endif).

Perhaps nsGtkMozRemoteHelper.h needs to include something to define NULL before
glib.h gets included (via gdktypes.h).

My workaround was to #include "nsString.h" *before* #including the
GTK and GDK headers.

Reproducible: Always
Steps to Reproduce:
Build script:

#!/bin/sh
GLIB=/opt/pkgs/GTKglib/v1.2.8
GTK=/opt/pkgs/GTKgtk/v1.2.8
LIBIDL=/opt/pkgs/MISCidl/v0.6.8
LD_LIBRARY_PATH=${GLIB}/lib:${GTK}/lib:${LIBIDL}/lib
PATH=$PATH:${GLIB}/bin:${GTK}/bin:${LIBIDL}/bin
export LD_LIBRARY_PATH PATH
#../mozilla/configure --prefix=/opt/pkgs/mozilla/$1 \
../mozilla/configure --prefix=/opt/pkgs/mozilla/$1 \
  --enable-x11-shm \
  --enable-optimize \
  --with-debug-modules \
  --enable-profiling \
  --enable-logrefcnt \
  --enable-leaky \
  --enable-mathml \
  && time gmake

Actual Results:  The build terminated with a series of warnings and error
messages.

Expected Results:  The build should have terminated successfully after building
a runaable mozilla.

Comment 1

[tor]

Slightly different fix checked in a couple hours ago (including stdlib.h in
nsGtkMozRemoteHelper.cpp before anything that would pull in glib.h).