420837 - "new Iterator()" throws a tautology

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js> new Iterator()
typein:1: TypeError: (void 0) is undefined

This isn't an especially helpful error message.  Even I don't know what it's trying to tell me.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

js> new Iterator()
typein:1: TypeError: Iterator is undefined

More to your liking?

Comment 2

[Jesse Ruderman]

Well, that's just false. I think that's worse than a tautology?

Comment 3

[Jesse Ruderman]

js> Iterator
function Iterator() {[native code]}

js> new Iterator()
typein:8: TypeError: Iterator is undefined

js> orly?

Comment 5

[Tom S [:evilpie]]

Attachment: v1

Well, I guess this can't hurt.

Comment 6

[Luke Wagner [:luke]]

Comment on attachment 624518 [details] [diff] [review]
v1

The logic looks fine.  r+ assuming f+ from dherman.

Comment 7

[Tom S [:evilpie]]

Attachment: v2

*sorry* This is really stupid, but the previous code put the argument[0] into *vp so after conversation it would be the return value.

Comment 8

[Dave Herman [:dherman]]

Comment on attachment 624536 [details] [diff] [review]
v2

Will this still give a weird error message for new Iterator(null)? Anyway, looks fine to me.

Dave

Comment 9

[Tom S [:evilpie]]

Thanks. Yes sadly still produces a rather weird error, because js_ValueToNonNullObject calls js_ReportIsNullOrUndefined, which is a bit hacky and doesn't fit the purpose here.

Comment 10

[Tom S [:evilpie]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/690c6018064d

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/690c6018064d