421348 - please QA the Phishing Protection page on the new Mozilla.com

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[John Slater]

Hi Stephen. Please QA as discussed.

Thanks,
John

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

The only thing I see is:

1) When JavaScript is disabled, the expand/collapse widgets disappear, and the heading doesn't shift left, so there's an empty space (minor UI nit)

(Page validates and all links work, so if we're not too concerned about the issue above we're good to go and you can mark it fixed; the missing artwork I'll track in a yet-to-be-created asset-checking bug.)

Comment 2

[Reed Loden [:reed]]

What about Malware Protection?

Comment 3

[Steven Garrity [:sgarrity]]

Stephen - the alignment issues when JS is disabled is fixed.

Reed: ?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED

Comment 5

[John Slater]

Quick update on this...I was talking to Mike Beltzner today and there are some likely changes to the functionality of the phishing and malware changes that could affect the content here a bit. 

He'll be chiming in soon with the details and background...stay tuned.

Comment 6

[John Slater]

Another update on this: I just filed Bug 432458 to incorporate the copy edits referred to in comment #5 above. As soon as they're complete, we should re-QA this page to make sure everything is working properly.

I'll follow up with Pascal about l10n issues in a separate thread.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

1) Broken link: "ttp://code.google.com/p/google-safe-browsing/wiki/Protocolv2Spec"
2) "Attackers will often hack a site to turn it into an attack site" -- "attack site" should be capitalized to be consistent.
3) Page doesn't validate
4) On Linux, the instructions read, "Tools > Options ... > Security", which should be "Edit > Preferences > Security"--we've got Linux correct on other pages like https://www-firefox3.authstage.mozilla.com/en-US/firefox/tips/

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

5) Can we tighten up the vertical footer space again?

Comment 9

[Steven Garrity [:sgarrity]]

(In reply to comment #7)
> 1) Broken link:
> 2) "attack site" should be capitalized to be consistent.
> 3) Page doesn't validate

1, 2, and 3 fixed in r12946.

> 4) On Linux, the instructions read, "Tools > Options ... > Security", which
> should be "Edit > Preferences > Security"--we've got Linux correct on other
> pages like https://www-firefox3.authstage.mozilla.com/en-US/firefox/tips/

Added Linux-specific menu location. I left off the ellipses after Options for Linux as it doesn't seem to be there in the menus.

I also replaced the three periods with a proper ellipses character (and removed the space before it) in all cases.

As for the vertical footer space, I think this is as tight as we can get it without the gradient looking too abrupt on shorter pages (with no scrolling).

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

6) Sorry Steven, I missed one, "You can learn more about attack sites" (capitalize).
7) "Firefox 3 or later contains a built-in Phishing and Malware Protection to help keep you safe online. These features..." -- does it seem odd to anyone else that it's singular ("a") in the first sentence, and plural "These features..." in the next?  Can we just drop the indefinite article "a"?

Comment 11

[Johnathan Nightingale [:johnath]]

(In reply to comment #10)
> 6) Sorry Steven, I missed one, "You can learn more about attack sites"
> (capitalize).
> 7) "Firefox 3 or later contains a built-in Phishing and Malware Protection to
> help keep you safe online. These features..." -- does it seem odd to anyone
> else that it's singular ("a") in the first sentence, and plural "These
> features..." in the next?  Can we just drop the indefinite article "a"?

Yep, that's an oopsie on my part.  I realised while writing copy that treated it as a single feature, that it was really two features, and went through to refer to them in the plural.  Looks like I missed one.  Nice catch.

Comment 12

[Steven Garrity [:sgarrity]]

(In reply to comment #10)
> 6) Sorry Steven, I missed one, "You can learn more about attack sites"
> (capitalize).
> 7) "Firefox 3 or later contains a built-in Phishing and Malware Protection to
> help keep you safe online. These features..." -- does it seem odd to anyone
> else that it's singular ("a") in the first sentence, and plural "These
> features..." in the next?  Can we just drop the indefinite article "a"?

Both done in r13014.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Argh.

8) (?): "Attackers will often hack a site to turn it into an Attack Site, and sometimes the web site's owner won't even know that this has happened." -- capitalize "web", and we're done here?  Sorry for the iteration. :-(

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

I should've done a CTRL+F; there are other instances of s/web/Web:

9) "Phishing attacks usually come from email messages that attempt to lure the recipient into updating their personal information on fake, but very real looking, web sites."
10) "Attack Sites are web sites that try to infect your computer with malware when you visit."

Steven, again, sorry for missing these.

Comment 15

[Steven Garrity [:sgarrity]]

(In reply to comment #14)
> I should've done a CTRL+F; there are other instances of s/web/Web:
Got these in r13082.

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks again for your patience.