421552 - allow users to send a crash report and quit firefox

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: changes ReportPreSubmit, Quit and CommentGrayText

The current crash reporter doesn't allow users to submit a crash report but *not* restart Firefox, which is pretty frustrating for people who want to submit reports but don't want to get caught in an infinite loop of crashes. There are other ways around it, but we should support the "send then quit" scenario.

Attached is a patch which makes the required string changes. I'll need some help:

 - changing the logic so if the checkbox is selected we send the report before quitting
 - changing the way the quit button is constructed to take the %s parameter

(the change to CommentGrayText is cosmetic and doesn't need an entity change)

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 307988 [details] [diff] [review]
changes ReportPreSubmit, Quit and CommentGrayText

>-# LOCALIZATION NOTE (Restart): The %s is replaced with the product name.
>+# LOCALIZATION NOTE (Quit2, Restart): The %s is replaced with the product name.
>+Quit2=Quit %s
> Restart=Restart %s

I think you are supposed to have one localization note per-entity that needs it.

r=me, obviously we'll need code changes to go along with this.

*sigh*

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: changes strings, adds maybeSubmitReport to linux and osx

Thanks for the help, Ted. Here's a patch that adds a maybeSubmitReport method on OSX and Linux (already had it on w32) and changes things so that both the close and restart buttons use it.

Includes the previous string changes and your nit on localization notes.

Submitted this to the tryserver just now, as well.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 308003 [details] [diff] [review]
changes strings, adds maybeSubmitReport to linux and osx

r=me assuming your second round of try server builds succeed (after you've fixed the ST_QUIT2 typo).

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: changes strings, adds maybeSubmitReport to linux and osx (v3)

I outsmarted myself.

Resubmitted to tryserver!

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 308008 [details] [diff] [review]
changes strings, adds maybeSubmitReport to linux and osx (v3)

I already gave you r+! Here, take it again!

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: changes strings, adds maybeSubmitReport to linux and osx (v4)

Carrying over review. Tested on OSX and Win32 successfully. Just changing the "Submitting your report..." string as well with this new patch, since we're no longer sure that we're restarting.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: changes strings, adds maybeSubmitReport to linux and osx (v4)

(sigh, as a patch this time)

Comment 8

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 308028 [details] [diff] [review]
changes strings, adds maybeSubmitReport to linux and osx (v4)

Oh yes.  Oh very yes.

a=shaver

Comment 9

[(not currently active) Ted Mielczarek]

Checking in toolkit/crashreporter/client/crashreporter.cpp;

/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter.cpp,v  <--  crashreporter.cpp

new revision: 1.20; previous revision: 1.19

done

Checking in toolkit/crashreporter/client/crashreporter.h;

/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter.h,v  <--  crashreporter.h

new revision: 1.13; previous revision: 1.12

done

Checking in toolkit/crashreporter/client/crashreporter_linux.cpp;

/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter_linux.cpp,v  <--  crashreporter_linux.cpp

new revision: 1.16; previous revision: 1.15

done

Checking in toolkit/crashreporter/client/crashreporter_osx.h;

/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter_osx.h,v  <--  crashreporter_osx.h

new revision: 1.9; previous revision: 1.8

done

Checking in toolkit/crashreporter/client/crashreporter_osx.mm;

/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter_osx.mm,v  <--  crashreporter_osx.mm

new revision: 1.19; previous revision: 1.18

done

Checking in toolkit/crashreporter/client/crashreporter_win.cpp;

/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter_win.cpp,v  <--  crashreporter_win.cpp

new revision: 1.24; previous revision: 1.23

done

Checking in toolkit/locales/en-US/crashreporter/crashreporter.ini;

/cvsroot/mozilla/toolkit/locales/en-US/crashreporter/crashreporter.ini,v  <--  crashreporter.ini

new revision: 1.8; previous revision: 1.7

done