Closed Bug 421734 Opened 16 years ago Closed 16 years ago

fx dialog checkboxes and radios positioned too high

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9beta5

People

(Reporter: tuukka.tolvanen, Assigned: dbaron)

References

Details

Attachments

(2 files)

screenshot
56.98 KB, image/png
Details
patch
841 bytes, patch
ventnor.bugzilla
: review+
roc
: superreview+
damons
: approval1.9+
Details | Diff | Splinter Review
Attached image screenshot — 
linux firefox trunk 2008-03-08-00Z

I guess this would be due to bug 402940, don't know whether to blame core, or theme for possibly assuming something wrong, picking one at random :)
Component: Theme → Layout: Form Controls
Product: Firefox → Core
QA Contact: theme → layout.form-controls
Flags: blocking1.9?
Possible it's a theme issue, but I'm going to guess Core issue for now.
dbaron, is there anything you need to change in XUL code to get this working? Because the controls were aligned perfectly in XUL before so I assume some kind of hack was used.
So whats happening now is that the radios and checkboxes are being drawn at the top of the frame they are given. vertical-align: middle doesn't work, but I imagine there might be some XUL magic to get it working...
And guess what, the assertion that I put in in that patch was firing, to show exactly what the problem was.

Patch shortly.
Assignee: nobody → dbaron
Attached patch patch — — Splinter Review 

        Attachment #308242 -
        Flags: superreview?(roc)

        Attachment #308242 -
        Flags: review?(ventnor.bugzilla)

    
    

    
  
Comment on attachment 308242 [details] [diff] [review]
patch

/me hunts a crow to eat

        Attachment #308242 -
        Flags: review?(ventnor.bugzilla) → review+

    
  
Component: Layout: Form Controls → Widget: Gtk
QA Contact: layout.form-controls → gtk

        Attachment #308242 -
        Flags: superreview?(roc) → superreview+

    
    

    
  
Comment on attachment 308242 [details] [diff] [review]
patch

bad regression from a patch that landed a few days ago, just reverts a tiny part of that patch

        Attachment #308242 -
        Flags: approval1.9?

    
    

    
  
Marking this as wanted1.9.0.x as well as approving the patch.  
Flags: wanted1.9.0.x+
Flags: blocking1.9?
Flags: blocking1.9-

    
    

    
  
Comment on attachment 308242 [details] [diff] [review]
patch

a1.9+=damons

        Attachment #308242 -
        Flags: approval1.9? → approval1.9+

    
    

    
  
Fix checked in to trunk, 2008-03-12 15:03 -0700.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5

    
    

    
  
v trunk 2008051611
Status: RESOLVED → VERIFIED
Flags: wanted1.9.0.x+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: