Closed
Bug 421947
Opened 16 years ago
Closed 16 years ago
More C++ casts required for Windows only, especially overloaded pow() and log10()
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta5
People
(Reporter: benjamin, Assigned: benjamin)
Details
Attachments
(1 file)
|
1.34 KB,
patch
|
crowderbt
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
These were build errors for me on mozilla-central, but the tinderbox is green. Anyway, these look correct and useful in any case.
Attachment #308459 -
Flags: review?(crowder)
|
||
Updated•16 years ago
|
Attachment #308459 -
Flags: review?(crowder) → review+
|
Assignee | |
Comment 1•16 years ago
|
||
Comment on attachment 308459 [details] [diff] [review] more casts to make C++ happy, rev. 1 very low-risk
Attachment #308459 -
Flags: approval1.9?
|
||
Comment 2•16 years ago
|
||
Comment on attachment 308459 [details] [diff] [review] more casts to make C++ happy, rev. 1 a1.9+=damons
Attachment #308459 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Updated•16 years ago
|
Assignee: general → benjamin
|
|
||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Version: unspecified → Trunk
|
|
||
Comment 3•16 years ago
|
||
Checking in js/src/jsinterp.c; /cvsroot/mozilla/js/src/jsinterp.c,v <-- jsinterp.c new revision: 3.471; previous revision: 3.470 done Checking in js/src/jsutil.c; /cvsroot/mozilla/js/src/jsutil.c,v <-- jsutil.c new revision: 3.30; previous revision: 3.29 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta5
|
||
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•