422463 - configure fails on x86_64 if pyxpcom is enabled

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Marco Pesenti Gritti]

It looks for libpython2.5.so.1.0 in /usr/lib but not in /usr/lib64.

Comment 1

[Marco Pesenti Gritti]

Attachment: Check for libpython also in /usr/lib64

Comment 2

[Benjamin Smedberg]

Comment on attachment 308908 [details] [diff] [review]
Check for libpython also in /usr/lib64

Seems like we should only check for lib64 on certain targets, right? Anyway, I'm not the pyxpcom maintainer.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Is the patch to configure needed?  IIUC, the update and checkin of configure will happen automatically once configure.in is installed.

Further, I'm not confident this is enough to get pyxpcom working correctly in a x64 environment - and if it doesn't, this patch doesn't offer anything.  Can you please confirm that pyxpcom does work correctly with an x64 build of python, and indicate what version of python you tested with, and how you created the build (ie, how did the libs end up in the lib64 directory in the first place?).

Comment 4

[Marco Pesenti Gritti]

(In reply to comment #3)
> Is the patch to configure needed?  IIUC, the update and checkin of configure
> will happen automatically once configure.in is installed.

Ah, you are right, I didn't know about that.

> Further, I'm not confident this is enough to get pyxpcom working correctly in a
> x64 environment - and if it doesn't, this patch doesn't offer anything.

I *think* it used to work. But I'm getting the following trace with the latest trunk. I don't know if it's x64 specific, I will investigate.

[marco@localhost python]$ python -c "from xpcom.components import components"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "xpcom/components.py", line 231, in <module>
    import shutdown
  File "/usr/lib64/xulrunner-1.9pre/python/xpcom/shutdown.py", line 51, in <module>
    class _ShutdownObserver:
  File "/usr/lib64/xulrunner-1.9pre/python/xpcom/shutdown.py", line 52, in _ShutdownObserver
    _com_interfaces_ = interfaces.nsIObserver
  File "xpcom/components.py", line 103, in __getattr__
    return self._get_o[marco@localhost python]$ python -c "from xpcom.components import components"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "xpcom/components.py", line 231, in <module>
    import shutdown
  File "/usr/lib64/xulrunner-1.9pre/python/xpcom/shutdown.py", line 51, in <module>
    class _ShutdownObserver:
  File "/usr/lib64/xulrunner-1.9pre/python/xpcom/shutdown.py", line 52, in _ShutdownObserver
    _com_interfaces_ = interfaces.nsIObserver
  File "xpcom/components.py", line 103, in __getattr__
    return self._get_one(attr)
  File "xpcom/components.py", line 153, in _get_one
    raise xpcom.COMException(nsError.NS_ERROR_NO_INTERFACE, "The interface '%s' does not exist" % (name,))
xpcom.Exception: -2147467262 (-2147467262)
ne(attr)
  File "xpcom/components.py", line 153, in _get_one
    raise xpcom.COMException(nsError.NS_ERROR_NO_INTERFACE, "The interface '%s' does not exist" % (name,))
xpcom.Exception: -2147467262 (-2147467262)

> Can
> you please confirm that pyxpcom does work correctly with an x64 build of
> python, and indicate what version of python you tested with, and how you
> created the build (ie, how did the libs end up in the lib64 directory in the
> first place?).

I'm using Fedora rawhide rpm. Looks like there is patch to make it install in lib64... I think Fedora 8 python does the same.

Comment 5

[Marco Pesenti Gritti]

I take that back. It's working fine on x64 as long as you bootstrap xpcom correctly (I'm using it in an embedding application).

Comment 6

[Marco Pesenti Gritti]

Note that, even with the patch, only python/xpcom is building, python/dom is failing for a different problem.

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 308908 [details] [diff] [review]
Check for libpython also in /usr/lib64

r=me for the configure.in changes

Comment 8

[Damon Sicore (:damons)]

Comment on attachment 308908 [details] [diff] [review]
Check for libpython also in /usr/lib64

a1.9+=damons

Comment 9

[Marco Pesenti Gritti]

Checked in.

Comment 10

[lkcl]

https://bugzilla.mozilla.org/show_bug.cgi?id=461652

nsdom fails.

quote from http://webui.sourcelabs.com/fedora/issues/436581 :

"The pydom error is probably another instance of this one:
 http://benjamin.smedbergs.us/blog/2005-10-27/gcc-40-workaround/
 In fact compiling with ac_cv_visibility_pragma=no works."