Closed
Bug 422818
Opened 16 years ago
Closed 16 years ago
Install element uses variable in _()
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: clouserw, Unassigned)
Details
In views/elements/install.thtml there are a few lines similar to: sprintf(_($buttonMessage),$_install_platform_string) This isn't going to work because $buttonMessage is a variable and needs to be a string so gettext can pick it up. It's working right now because the string a_install is left over from a while ago, but gettext is trying to deprecate it now because it's not used anywhere that it can see.
Comment 1•16 years ago
|
||
Good catch. If we need to assign gettext strings to a variable, we should always keep intact the _('some_static_text') pattern because the gettext tools read the code files statically.
Comment 2•16 years ago
|
||
This is fixed since r11552.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•