Closed
Bug 422887
Opened 16 years ago
Closed 16 years ago
artwork for about:robots
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3 beta5
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(4 files)
88.23 KB,
image/png
|
Details | |
3.63 KB,
patch
|
beltzner
:
review+
beltzner
:
ui-review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
66.83 KB,
image/jpeg
|
Details | |
2.14 KB,
patch
|
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
Got the icon artwork from tara/jslater today. This visually ties in the about:robots page to the beta firstrun pages. [eg, http://www.mozilla.com/en-US/firefox/3.0b4/firstrun/]
Assignee | ||
Comment 1•16 years ago
|
||
Assignee: nobody → dolske
Status: NEW → ASSIGNED
Attachment #309369 -
Flags: ui-review?(beltzner)
Attachment #309369 -
Flags: review?(beltzner)
Updated•16 years ago
|
Attachment #309369 -
Flags: ui-review?(beltzner)
Attachment #309369 -
Flags: ui-review+
Attachment #309369 -
Flags: review?(beltzner)
Attachment #309369 -
Flags: review+
Updated•16 years ago
|
Attachment #309369 -
Flags: approval1.9+
Assignee | ||
Comment 2•16 years ago
|
||
Checking in browser/base/jar.mn; new revision: 1.122; previous revision: 1.121 Checking in browser/base/content/aboutRobots-icon.png; initial revision: 1.1 Checking in browser/base/content/aboutRobots-widget-left.png; initial revision: 1.1 Checking in browser/base/content/aboutRobots-widget-right.png; initial revision: 1.1 Checking in browser/base/content/aboutRobots.xhtml; new revision: 1.2; previous revision: 1.1
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
Comment 4•16 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b5pre) {Build ID: 2008031423} These images seem to be broken. These cannot be opened even by Firefox and other image viewers.
Comment 5•16 years ago
|
||
<div id="errorPageContainer" style="background: url('chrome://browser/content/aboutRobots-icon.png') left 0 no-repeat -moz-Field; -moz-background-origin: content;"> > -moz-Field; background-color of #errorPageContainer is different in each theme. This is not themeble. https://bugzilla.mozilla.org/show_bug.cgi?id=417302#c53
Assignee | ||
Comment 6•16 years ago
|
||
Oops. Too much cut'n'paste, so the icons were being preprocessed. The clever PNG header was the tipoff.
Assignee | ||
Comment 7•16 years ago
|
||
(In reply to comment #5) > This is not themeble. It's just a whimsical page so I don't think themeability is a big concern here. If there's a trivial one-line fix, it might be accepted although the tree is basically in a blockers-only state now.
Comment 8•16 years ago
|
||
(In reply to comment #7) > (In reply to comment #5) > > > This is not themeble. > > It's just a whimsical page so I don't think themeability is a big concern here. > If there's a trivial one-line fix, it might be accepted although the tree is > basically in a blockers-only state now. 1. about:robots use netError.css 2. A color scheme of netError.css is different in each theme. 3. aboutRobots.xhtml hardcoding background-color of #errorPageContainer. 4. aboutRobots.xhtml doesn't have special id or class. 5. Themer doesn't have the method of adjusting about:robots. Actually, I found a tricky method. However, I do'nt think that this method is good.
Updated•16 years ago
|
Attachment #309697 -
Flags: approval1.9+
You need to log in
before you can comment on or make changes to this bug.
Description
•