422887 - artwork for about:robots

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: screenshot

Got the icon artwork from tara/jslater today. This visually ties in the about:robots page to the beta firstrun pages. [eg, http://www.mozilla.com/en-US/firefox/3.0b4/firstrun/]

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Comment 2

[Justin Dolske [:Dolske]]

Checking in browser/base/jar.mn;
  new revision: 1.122; previous revision: 1.121
Checking in browser/base/content/aboutRobots-icon.png;
  initial revision: 1.1
Checking in browser/base/content/aboutRobots-widget-left.png;
  initial revision: 1.1
Checking in browser/base/content/aboutRobots-widget-right.png;
  initial revision: 1.1
Checking in browser/base/content/aboutRobots.xhtml;
  new revision: 1.2; previous revision: 1.1

Comment 3

[pal-moz]

Attachment: screenshot

20080315_0012_firefox-3.0b5pre.en-US.win32.zip

no images.

Comment 4

[AKIHIRO Misaki (a.k.a Kuden)]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b5pre) {Build ID: 2008031423}

These images seem to be broken. 
These cannot be opened even by Firefox and other image viewers. 

Comment 5

[AKIHIRO Misaki (a.k.a Kuden)]

    <div id="errorPageContainer"
         style="background: url('chrome://browser/content/aboutRobots-icon.png') left 0 no-repeat -moz-Field; -moz-background-origin: content;">

> -moz-Field;
background-color of #errorPageContainer is different in each theme. 
This is not themeble. 

https://bugzilla.mozilla.org/show_bug.cgi?id=417302#c53

Comment 6

[Justin Dolske [:Dolske]]

Attachment: Manifest fix

Oops. Too much cut'n'paste, so the icons were being preprocessed. The clever PNG header was the tipoff.

Comment 7

[Justin Dolske [:Dolske]]

(In reply to comment #5)

> This is not themeble. 

It's just a whimsical page so I don't think themeability is a big concern here. If there's a trivial one-line fix, it might be accepted although the tree is basically in a blockers-only state now.

Comment 8

[AKIHIRO Misaki (a.k.a Kuden)]

(In reply to comment #7)
> (In reply to comment #5)
> 
> > This is not themeble. 
> 
> It's just a whimsical page so I don't think themeability is a big concern here.
> If there's a trivial one-line fix, it might be accepted although the tree is
> basically in a blockers-only state now.

1. about:robots use netError.css
2. A color scheme of netError.css is different in each theme. 
3. aboutRobots.xhtml hardcoding background-color of #errorPageContainer.
4. aboutRobots.xhtml doesn't have special id or class.
5. Themer doesn't have the method of adjusting about:robots. 

Actually, I found a tricky method. However, I do'nt think that this method is good.