423137 - Handle ratings change from bug 417442

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Dave Townsend [:mossop]]

AMO are planning on dropping their maximum rating from 10 to 5. We need to handle that.

Most likely the easiest is just to double the value in nsAddonRepository.js before passing out.

The alternative involves changing the idl contract and the skin code as well.

Comment 1

[Dave Townsend [:mossop]]

Attachment: trivial patch

This is the trivial version of the fix. Means the nsIAddonRepository still outputs ratings from 0-10

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 309644 [details] [diff] [review]
trivial patch

r=me

Is changing the idl contract and the skin code a better approach? Seems better for the long term.

Comment 3

[Dave Townsend [:mossop]]

Attachment: fuller patch

Maybe it is. This is the fuller patch, adjusts the idl comment and changes the style rules to deal with 0-5 values.

Wasn't sure if we're expected to rev the uuid when results from interfaces change like that so I just did anyway.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 310063 [details] [diff] [review]
fuller patch

surely that isn't the patch?

Comment 5

[Dave Townsend [:mossop]]

Attachment: the real patch

Ummm oops!

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 310068 [details] [diff] [review]
the real patch

r=me

the uuid change isn't necessary.

Comment 7

[Dave Townsend [:mossop]]

Fixed in the code. This will look a little odd till the server side is updated which is now scheduled for Thursday.

Checking in toolkit/mozapps/extensions/public/nsIAddonRepository.idl;
/cvsroot/mozilla/toolkit/mozapps/extensions/public/nsIAddonRepository.idl,v  <--  nsIAddonRepository.idl
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/themes/gnomestripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.18; previous revision: 1.17
done
Checking in toolkit/themes/pinstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.41; previous revision: 1.40
done
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.50; previous revision: 1.49
done

Comment 8

[pal-moz]

star image is broken ?

http://img164.imageshack.us/img164/2607/a3iw2.jpg

Comment 9

[David Quintana]

I  have a theme based on the official code, and I solved this problem adding a default -moz-image-region attribute to .addonRating[rating], and marking the specific ones as !important. Hope this helps.

Comment 10

[David Quintana]

(In reply to comment #8)
> star image is broken ?
> 
> http://img164.imageshack.us/img164/2607/a3iw2.jpg
> 

(In reply to comment #9)
> I  have a theme based on the official code, and I solved this problem adding a
> default -moz-image-region attribute to .addonRating[rating], and marking the
> specific ones as !important. Hope this helps.
> 

Forgot to say it was replying to comment #8. 

Comment 11

[Dave Townsend [:mossop]]

(In reply to comment #8)
> star image is broken ?
> 
> http://img164.imageshack.us/img164/2607/a3iw2.jpg

Please read comment 7 where I pointed out that this will look a little odd until the server side is fixed tomorrow.

Comment 12

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050206 Minefield/3.0pre