Closed
Bug 423361
Opened 16 years ago
Closed 16 years ago
[proto] Land Proto 0.14 changes
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 3 beta5
People
(Reporter: kevin, Assigned: kevin)
References
()
Details
Attachments
(2 files, 1 obsolete file)
30.73 KB,
patch
|
rflint
:
review+
|
Details | Diff | Splinter Review |
168.45 KB,
application/x-gzip
|
Details |
Proto 0.14 changes - redesigned toolbar gradient and tab bar so that tab color will not stand out when bookmark bar is hidden or shown - fixed bookmark bar hover images - transparent tabs - etched text on status bar - some new icons from Stephen including pref window icons
Attachment #309861 -
Flags: ui-review?(beltzner)
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → kevin
Assignee | ||
Updated•16 years ago
|
Attachment #309861 -
Flags: review?(rflint)
Assignee | ||
Updated•16 years ago
|
Comment 1•16 years ago
|
||
I've added a couple more bugs to the dependency tree here based on their appearing to be fixed by this update. one downside with this proto update, my main browser scrollbar seems to go away.
Comment 2•16 years ago
|
||
Comment on attachment 309861 [details] [diff] [review] Patch against trunk. See Proto 0.14 theme on AMO to test >diff -u -p -8 -r1.132 browser.css > toolbar[mode="icons"] #back-button .toolbarbutton-text-box, > toolbar[mode="icons"] #forward-button .toolbarbutton-text-box, >-#back-button .toolbarbutton-menubutton-dropmarker, >-#forward-button .toolbarbutton-menubutton-dropmarker { >+#back-button > vbox > hbox > dropmarker, >+#forward-button > vbox > hbox > dropmarker, >+#back-button > dropmarker, >+#forward-button > dropmarker { > display: none; > } Why does this dropmarker element even exist?
Updated•16 years ago
|
Flags: blocking-firefox3?
Assignee | ||
Comment 3•16 years ago
|
||
(In reply to comment #1) > one downside with this proto update, my main browser scrollbar seems to go > away. Ah, I missed a recent scrollbar css change. I've submitted Proto 0.14.1 which should have happy scrollbars. The patch doesn't change though.
Assignee | ||
Comment 4•16 years ago
|
||
Comment on attachment 309861 [details] [diff] [review] Patch against trunk. See Proto 0.14 theme on AMO to test Dao, can you review the patch please?
Attachment #309861 -
Flags: review?(rflint) → review?(dao)
Comment 5•16 years ago
|
||
Comment on attachment 309861 [details] [diff] [review] Patch against trunk. See Proto 0.14 theme on AMO to test Great work, Kevin. Don't forget to tell me what kind of scotch you like ...
Attachment #309861 -
Flags: ui-review?(beltzner) → ui-review+
Comment 6•16 years ago
|
||
Comment on attachment 309861 [details] [diff] [review] Patch against trunk. See Proto 0.14 theme on AMO to test I'm not a peer and I don't have OS X, so I'm by far not the best candidate :) >+#main-window[chromehidden="toolbar location directories "] { >+ border-top: 1px solid #606060; > } This like fragile. > toolbar[mode="icons"] #back-button .toolbarbutton-text-box, > toolbar[mode="icons"] #forward-button .toolbarbutton-text-box, >-#back-button .toolbarbutton-menubutton-dropmarker, >-#forward-button .toolbarbutton-menubutton-dropmarker { >+#back-button > vbox > hbox > dropmarker, >+#forward-button > vbox > hbox > dropmarker, >+#back-button > dropmarker, >+#forward-button > dropmarker { > display: none; > } see comment 2 If the dropmarker doesn't belong there, it should be removed from pinstripe's browser.xml. >+#nav-bar[collapsed="true"] + toolbar[id*="customToolbar"] { >+ border-top: 2px solid; >+ -moz-border-top-colors: #606060 #C7C7C7; >+} use |#nav-bar[collapsed="true"] + toolbar[customindex]|?
Attachment #309861 -
Flags: review?(dao) → review?(gavin.sharp)
Comment 7•16 years ago
|
||
> >+#main-window[chromehidden="toolbar location directories "] {
> >+ border-top: 1px solid #606060;
> > }
>
> This like fragile.
interesting ...
I wanted to say that the attribute selector looks fragile.
Assignee | ||
Comment 8•16 years ago
|
||
(In reply to comment #7) > interesting ... > I wanted to say that the attribute selector looks fragile. > Yes. I wanted to put a border on the window title bar when you hide the chrome via the pill button. I couldn't find another way to put the border on. I could remove the rule for now if it could be problematic.
Comment 9•16 years ago
|
||
How about: #main-window[chromehidden~="toolbar"][chromehidden~="location"][chromehidden~="directories"] {
Assignee | ||
Comment 10•16 years ago
|
||
Thanks for the feedback Dao!
Attachment #309861 -
Attachment is obsolete: true
Attachment #309985 -
Flags: review?(gavin.sharp)
Attachment #309861 -
Flags: review?(gavin.sharp)
Comment 11•16 years ago
|
||
Would like to have this for B5, so blocking P1.
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P1
Target Milestone: --- → Firefox 3 beta5
Assignee | ||
Comment 12•16 years ago
|
||
Assignee | ||
Comment 13•16 years ago
|
||
Can someone please check the last patch in for me along with the attached images, after it gets reviewed?. I hesitate to ask but I'm going on holiday and I'm not going to be in communication range for the next 10 days.
Comment 14•16 years ago
|
||
Yes, somebody will do that. It's blocking now, so it won't be lost.
Updated•16 years ago
|
Hardware: PC → All
Version: unspecified → Trunk
Updated•16 years ago
|
Attachment #309985 -
Flags: review?(gavin.sharp) → review?(rflint)
Comment 15•16 years ago
|
||
Comment on attachment 309985 [details] [diff] [review] Patch after incorporating Dao's suggestions mozilla/browser/themes/pinstripe/browser/preferences/Options.png 1.10 mozilla/browser/themes/pinstripe/browser/preferences/plugin.png 1.3 mozilla/browser/themes/pinstripe/browser/preferences/preferences.css 1.26 mozilla/browser/themes/pinstripe/browser/places/organizer.css 1.6 mozilla/browser/themes/pinstripe/browser/tabbrowser/alltabs-box-bkgnd.png 1.4 mozilla/browser/themes/pinstripe/browser/tabbrowser/tab-arrow-end-bkgnd.png 1.4 mozilla/browser/themes/pinstripe/browser/tabbrowser/tab-arrow-start-bkgnd.png 1.3 mozilla/browser/themes/pinstripe/browser/tabbrowser/tab-left-bkgnd.png 1.4 mozilla/browser/themes/pinstripe/browser/tabbrowser/tab-left.png 1.4 mozilla/browser/themes/pinstripe/browser/tabbrowser/tab-middle-bkgnd.png 1.4 mozilla/browser/themes/pinstripe/browser/tabbrowser/tab-middle.png 1.4 mozilla/browser/themes/pinstripe/browser/tabbrowser/tab-right-bkgnd.png 1.4 mozilla/browser/themes/pinstripe/browser/tabbrowser/tab-right.png 1.4 mozilla/browser/themes/pinstripe/browser/tabbrowser/tabbrowser-tabs-bkgnd.png 1.4 mozilla/browser/themes/pinstripe/browser/Go-arrow.png 1.3 mozilla/browser/themes/pinstripe/browser/Popup-blocked.png 1.3 mozilla/browser/themes/pinstripe/browser/Search-bar.png 1.4 mozilla/browser/themes/pinstripe/browser/Search.png 1.4 mozilla/browser/themes/pinstripe/browser/bookmark_toolbar_background.gif 1.5 mozilla/browser/themes/pinstripe/browser/browser.css 1.134 mozilla/browser/themes/pinstripe/browser/browser.xml 1.7 mozilla/browser/themes/pinstripe/browser/identity.png 1.3 mozilla/browser/themes/pinstripe/browser/page-livemarks.png 1.5 mozilla/toolkit/themes/pinstripe/global/globalBindings.xml 1.25 mozilla/toolkit/themes/pinstripe/global/toolbar.css 1.16 mozilla/toolkit/themes/pinstripe/global/toolbar/toolbar-background-tall.gif 1.2 mozilla/toolkit/themes/pinstripe/global/toolbar/toolbar-background.gif 1.4 mozilla/toolkit/themes/pinstripe/global/toolbar/toolbarbutton-customhover-left.png 1.2 mozilla/toolkit/themes/pinstripe/global/toolbar/toolbarbutton-customhover-mid.png 1.2 mozilla/toolkit/themes/pinstripe/global/toolbar/toolbarbutton-customhover-right.png 1.2 mozilla/toolkit/themes/pinstripe/mozapps/plugins/pluginGeneric.png 1.3 mozilla/toolkit/themes/pinstripe/global/console/console.css 1.13 mozilla/toolkit/themes/pinstripe/global/tree/folder.png 1.4
Attachment #309985 -
Flags: review?(rflint) → review+
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 16•16 years ago
|
||
See bug 423361 about the dropmarkers for back/forward that should not be there.
Comment 17•16 years ago
|
||
Alfred, did you mean to cite a different bug number?
Comment 18•16 years ago
|
||
Indeed, I am referring to bug 414445.
You need to log in
before you can comment on or make changes to this bug.
Description
•