423578 - Cancelling a search in the Bookmarks Manager resets open folders

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I feel like this is a dupe, but I can't find it right now, so filing....  Chris probably knows which one it is, if it is filed already.

Cancelling/clearing any search in the Bookmarks Manager (bookmarks or history) clears the expanded folder state for the searched collection.

STR:

1) Have one or more folders expanded in any folder-capable Manager collection
2) Type something the search field
3) Cmd-., Esc, delete all the way, or click the (x) button in the field

AR: No folders expanded

ER: Folders expanded prior to searching are expanded at the end of the search

(Technically, just the act of entering a character is what kills folder state, since delete also doesn't restore.)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On the other hand, searching and then double-clicking on the result (thus leaving the Manager) *does* manage to preserve open folder state.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: fix

This annoyed me one too many times tonight, and mxr was very nice to me, so herewith another of my awesome couple-line Obj-C fixes.

Comment 3

[Chris Lawson (gone)]

Comment on attachment 345438 [details] [diff] [review]
fix

Looks good, works as advertised, and is going to rot me on 338558. Great. :-p

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 345438 [details] [diff] [review]
fix

sr=pink

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk!