42360 - SUNWspro5.0 build bustage in nsVoidBTree.h

Status: VERIFIED FIXED

(Core :: XPCOM, defect, P3)

Description

[tor]

CC -library=iostream -o nsVoidBTree.o -c -DOSTYPE=\"SunOS5\" -DOJI
-D_IMPL_NS_COM -D_IMPL_NS_BASE  -I../../dist/include
-I/cs/src/mozilla/mozilla/include -I/cs/lib/nspr/include   
-I/usr/openwin/include   -KPIC  -mt  -DDEBUG -DDEBUG_tor -DTRACING -g
-DMOZILLA_CLIENT -DBROKEN_QSORT=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1
-DULTRA_SPARC=1 -DD_INO=d_ino -DMOZ_WIDGET_GTK=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\"
-DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1
-DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1
-DHAVE_DIRENT_H=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_SYS_FILIO_H=1 -DHAVE_SYS_IPC_H=1 -DHAVE_SYS_SHM_H=1
-DHAVE_X11_EXTENSIONS_XSHM_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_SYS_MOUNT_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1
-DHAVE_LIBRESOLV=1 -DHAVE_LIBSOCKET=1 -DHAVE_LIBNSL=1 -DHAVE_LIBELF=1
-DHAVE_LIBINTL=1 -DHAVE_LIBPOSIX4=1 -DHAVE_LIBW=1 -D_REENTRANT=1 -DHAVE_RANDOM=1
-DHAVE_QSORT=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STATVFS=1 -DHAVE_MEMMOVE=1
-DHAVE_USLEEP=1 -DHAVE_GETTIMEOFDAY=1 -DGETTIMEOFDAY_TWO_ARGS=1
-DHAVE_DEV_ZERO=1 -DHAVE_IOS_BINARY=1 -DHAVE_OSTREAM=1 -DHAVE_CPP_EXPLICIT=1
-DHAVE_CPP_SPECIALIZATION=1 -DHAVE_CPP_MODERN_SPECIALIZE_TEMPLATE_SYNTAX=1
-DHAVE_CPP_ACCESS_CHANGING_USING=1 -DHAVE_CPP_AMBIGUITY_RESOLVING_USING=1
-DHAVE_CPP_NAMESPACE_STD=1 -DHAVE_CPP_UNAMBIGUOUS_STD_NOTEQUAL=1
-DHAVE_CPP_NEW_CASTS=1 -DNEED_CPP_UNUSED_IMPLEMENTATIONS=1
-DHAVE_I18N_LC_MESSAGES=1 -DMOZ_ENDER_LITE=1 -DNS_MT_SUPPORTED=1
-DDETECT_WEBSHELL_LEAKS=1 -DMOZ_USER_DIR=\".mozilla\" -DMOZ_MNG=1
-DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1
-DLAYERS=1  /cs/src/mozilla/mozilla/xpcom/ds/nsVoidBTree.cpp
"/cs/src/mozilla/mozilla/xpcom/ds/nsVoidBTree.h", line 180: Error:
nsVoidBTree::Node is not accessible from nsVoidBTree::Path::Link.
1 Error(s) detected.

Comment 1

[tor]

Smaller test case exhibiting the same problem:

"node.cc", line 12: Error: tree::Node is not accessible from tree::Path::Line.
1 Error(s) detected.

class tree {
  protected:
    class Node {
    };

  class Path;
  friend class Path;

  class Path {
    public:
      struct Line {
        Node *node;
      };
  };
};

Comment 2

[cls]

FYI, nebiros didn't have the recommended Workshop 5.0 patches.  I applied the
patches but it has yet to generate a build log since.

Comment 3

[tor]

FYI, this bug and the test case are from testing with the sunwspro installation
here, which does have the patches needed to compile mozilla.

Comment 4

[Chris Waterson]

tor: maybe try adding

  class Path::Line;
  friend class Path::Line;

out in tree? If that doesn't work, I can move Node to the outer scope.

Comment 5

[tor]

I had the same thought, but the compiler doesn't like it:

"node.cc", line 9: Error: tree::Path::Line is not defined.
"node.cc", line 10: Error: tree::Path::Line is not defined.

Comment 6

[leger]

Updating QA Contact to hong

Comment 7

[Chris Waterson]

ok, fix checked in.

Comment 8

[cls]

Verified.  WS 5.0 builds are now breaking in nsHashtable.h but I'm testing a fix
for that now.