423674 - Update to breakpad revision 250

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

Attachment: update from revision 240 to 250

I'd like to get Alfred's Solaris fixes in for b5 so they can ship Firefox with Breakpad there. This patch contains a lot of stuff, but most of it is in the processor code, and thus not really relevant to us. There are a few things in the Windows handler code, due to the out of process minidump writing landing, I'm taking a look at those now, and I'll spin some try server builds with this patch to be sure.

Comment 1

[Matthias Versen [:Matti]]

Is there a changelog somewhere ?

Comment 2

[(not currently active) Ted Mielczarek]

You can see the SVN revision log here:
http://code.google.com/p/google-breakpad/source/list

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: update from r240 to r250, without the windows client changes

Comment 4

[(not currently active) Ted Mielczarek]

Right, so, I decided not to import the windows client bits, to avoid any possible risk there. The only thing this patch touches that we actually build is src/google_breakpad/common/minidump_format.h, and that's just a refactoring of the contents of the file, no actual content changes.

Comment 5

[Robert Sayre]

Comment on attachment 310388 [details] [diff] [review]
update from r240 to r250, without the windows client changes

rs=sayrer, mostly npotb

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 310388 [details] [diff] [review]
update from r240 to r250, without the windows client changes

This patch is almost entirely NPOTB, and the part that is part of the build is just splitting one large header into several smaller header files. It's a prerequisite for Solaris breakpad support.

Comment 7

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 310388 [details] [diff] [review]
update from r240 to r250, without the windows client changes

the sweet sound
of patch-set approval
comin' down in a 
not quite freeze

(a=shaver)

Comment 8

[(not currently active) Ted Mielczarek]

Checked in.