424076 - Search in bookmarks loses sort (should use position key)

Status: REOPENED

(Firefox :: Bookmarks & History, defect, P5)

Description

[Thomas Bertels]

Attachment: Left image : default sort ; right image : search loses sort

When searching in the bookmarks, the bookmarks order isn't kept.

The moz_bookmarks table position key should be used to keep the order of the bookmarks.

Comment 1

[Marco Bonardo [:mak]]

are they ordered by last visited?

Comment 2

[Thomas Bertels]

No, and I didn't find how they are sorted. I used the SQLite Manager extension to try all the possibilities.

Note that if I remove one of these bookmarks, the order is then kept on search (so the bug isn't then reproduceable anymore).

Additionally, the "test" bookmark should be displayed as it doesn't contain an "a" in its title.

Comment 3

[Marco Bonardo [:mak]]

need to be investigated, probably not blocking though

can you post your build version?

Comment 4

[Thomas Bertels]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031905 Minefield/3.0b5pre

Comment 5

[Miles]

Confirmed sort frequently doesn't stick in 3.0, WinXP, although it sometimes does!   This is by sorting from organize bookmarks/choose a folder/sort/sort by name.  Apparently no difference if a short or long list. 

Comment 6

[Miles]

In 3.0.1 discovered that if sort by name/A-Z it will sort, but will not stick.  Go to another BM folder, return and it's returned to the original unsorted list.  However, if manually sort in alpha sequence without naming such in the sort dropdown it will stick.

Comment 7

[Thomas Bertels]

(In reply to comment #5 and #6)
> Confirmed sort frequently doesn't stick in 3.0, WinXP, although it sometimes
> does!   This is by sorting from organize bookmarks/choose a folder/sort/sort by
> name.  Apparently no difference if a short or long list. 
> 
This bug about the sort not being kept _when searching for some string_.

Comment 8

[David McRitchie]

#1 & #2 the order seen is Unsorted (because the sort does not stick for the
table), so the order is from each folder in the order the folders are seen on
the left, then in the order in which entries exist within folders.  Entirely
ordered down from the top of the folders list.

The problem addresses the listing itself in the right side panel, not the order
of the listing of the bookmarks themselves on the left side of the panel.  

The not sticking refers to the right side of the panel on which column is
chosen to be sorted after a search string (or column sort).  So #1 and #5 are
not in conflict with one another.   (See  Views menu, because you can't click
on a column for Unsorted)

Obviously a separate problem but is related to sorting -- cannot sort on
"Keyword" and get a consistent sort order.

Currently, for search results to be sorted on the right panel of Organize
Bookmarks list one has to sort on the column and that would always be temporary
as it stands now.  Not like right-click on a folder on the left side panel and
sorting (permanent change to order).

The order of the search listing is Unsorted since the sort column does not
stick and that order is determined by  what you have on the left panel of
Organize Bookmarks,  and would be more apparent if the "Parent" column were
added  to the listing.  

Install the  "Show Parent Folder"  https://addons.mozilla.org/firefox/7372
Choose the add-on option   'Show Folder hierarchy'.
In Organize Bookmarks,  right-click on column header (or use View menu)  to add
the "Parent Folder" column.  You can  drag to rearrange and/or resize columns, 
You will want the Parent Folder column fairly wide to see the hierarchy.

Comment 9

[Samuel Sidler (old account; do not CC)]

Not wanted for 1.9.0.x, but let's find an owner for this.

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 11

[Thomas Wolff]

Decent bookmarks searching is one of the widely missing features - there just doesn't seem to be much support for bookmarks management @mozilla.
Bookmarks search results have always come in some random order - even before the SQL bookmarks implementation (i.e. Firefox 2) - this is not helpful for bookmarks management at all, as well as the missing orientation within the bookmarks folder tree after search (cf. https://bugzilla.mozilla.org/show_bug.cgi?id=171575#c87).

Comment 12

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 13

[komalbharadiya]

Is this issue open? Can I work on this as a beginner? If yes, where is the sorting function/ code base related to this?

Comment 14

[Mark Banner (:standard8)]

(In reply to komalbharadiya from comment #13)

Is this issue open? Can I work on this as a beginner? If yes, where is the sorting function/ code base related to this?

I suspect this isn't a simple bug, and would need deeper investigation as to the issue. The sorting function should generally be correct (otherwise non-search wouldn't work), but it needs determining why that isn't being applied properly in the search case.

If you want to find simple and mentored bugs to work on, https://codetribute.mozilla.org/ is a good place to look.

Comment 15

[komalbharadiya]

(In reply to Mark Banner (:standard8) from comment #14)

(In reply to komalbharadiya from comment #13)

Is this issue open? Can I work on this as a beginner? If yes, where is the sorting function/ code base related to this?

I suspect this isn't a simple bug, and would need deeper investigation as to the issue. The sorting function should generally be correct (otherwise non-search wouldn't work), but it needs determining why that isn't being applied properly in the search case.

If you want to find simple and mentored bugs to work on, https://codetribute.mozilla.org/ is a good place to look.

Alright, thanks:)