424260 - Cannot upload new version of extension

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Gilles Durys]

Attachment: xpi I try to upload

When I try to a upload a new version of text/plain (https://addons.mozilla.org/en-US/firefox/addon/1864), I always get the following error:
"No install.rdf present.
Please see this page for reference."

The xpi I try to upload is attached.

Comment 1

[Jesse Ruderman]

I'm hitting the same problem with one of my extensions (Thumbs).

Comment 2

[Basil Hashem [:baz]]

Laura, do you think this might be another PHP5 bug that we are hitting up against?

Assigning to fligtar for investigation...

Comment 3

[Michael Morgan [:morgamic]]

Thought we tested this?

Comment 4

[Laura Thomson :laura]

Attachment: Patch to fix logic

This is an old logic error, which I don't think got invoked before because the RDF parser had a bug under PHP4.  This patch should give you a more informative error message (the RDF parser can't read your install.rdf since it has unicode characters in it.)

I think we *should* be able to parse them, so we'll have to hack on the RDF parser next.  Leaving that for tomorrow.

Comment 5

[Michael Morgan [:morgamic]]

Comment on attachment 310906 [details] [diff] [review]
Patch to fix logic

wfm; nice catch Laura

Comment 6

[Laura Thomson :laura]

Fixed in 3.1 in r11438.

Comment 7

[Laura Thomson :laura]

Merged to trunk in r11440.

Comment 8

[Jesse Ruderman]

Seems to be working now on AMO.

Comment 9

[Laura Thomson :laura]

Did this get pushed?  If so I'll close it.  If not I guess 3.2 will be pushed soon anyway.

Comment 10

[boaz.barnea]

Still happens to me even though this bug is marked "fixed"

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

This is a pretty old bug, so you should file a new one. However, I believe you already sent the file to us, so please be patient while we look into the problem.