Closed Bug 424363 Opened 16 years ago Closed 16 years ago

Customize Toolbar ▸ Restore Default Set uses gtk-refresh instead of gtk-revert-to-saved

Categories

(Firefox :: Theme, defect)

All
Linux
defect
Not set
trivial

Tracking

()

VERIFIED FIXED
Firefox 3.1b3

People

(Reporter: adelfino, Assigned: Dolske)

References

Details

(Keywords: polish, verified1.9.1, Whiteboard: [polish-easy] [polish-visual][polish-p2])

Attachments

(2 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032107 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032107 Minefield/3.0b5pre

Since we are not refreshing anything, but reverting changes gtk-undo should be used.

Reproducible: Always
Attached image Screenshot. (obsolete) —
Version: unspecified → Trunk
Summary: Customize Toolbar > Restore Default Set uses gtk-refresh instead of gtk-undo → Customize Toolbar ▸ Restore Default Set uses gtk-refresh instead of gtk-undo
Blocks: 381206
If anything, use gtk-revert-to-saved. The icon gtk-undo is for undoing one step, which is not the case here. So, gtk-revert-to-saved or no icon.
(In reply to comment #2)
> If anything, use gtk-revert-to-saved. The icon gtk-undo is for undoing one
> step, which is not the case here. So, gtk-revert-to-saved or no icon.
> 

You're absolutely right; actually, I was going to morph this bug.

I think the gtk-revert-to-saved works fine here.
Summary: Customize Toolbar ▸ Restore Default Set uses gtk-refresh instead of gtk-undo → Customize Toolbar ▸ Restore Default Set uses gtk-refresh instead of gtk-revert-to-saved
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: All → Linux
Keywords: polish
Whiteboard: [polish-easy] [polish-visual]
Attached patch Patch v.1Splinter Review
Assignee: nobody → dolske
Attachment #310989 - Attachment is obsolete: true
Attachment #350557 - Flags: review?(gavin.sharp)
Attached image Screenshot (patch v.1)
Attachment #350558 - Flags: ui-review?(faaborg)
(New icon is the top in the screenshot, old icon is the bottom).

The change to customizeToolbarSheet.xul probably isn't needed (seems to be mac only), but I figured I'd just keep them more or less in sync.
Attachment #350557 - Flags: review?(gavin.sharp) → review+
Comment on attachment 350557 [details] [diff] [review]
Patch v.1

>diff --git a/toolkit/content/customizeToolbar.xul b/toolkit/content/customizeToolbar.xul

>+    <button label="&restoreDefaultSet.label;" oncommand="restoreDefaultSet();"
>+icon="revert"/>

What's with the odd indent?
Comment on attachment 350558 [details]
Screenshot (patch v.1)

I'm assuming these are the correct icons. I actually don't know what gtk-revert-to-saved looks like.
Attachment #350558 - Flags: ui-review?(faaborg) → ui-review+
Attachment #350557 - Flags: approval1.9.1?
Pushed http://hg.mozilla.org/mozilla-central/rev/f03bb4a3ce53
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment on attachment 350557 [details] [diff] [review]
Patch v.1

a191=beltzner
Attachment #350557 - Flags: approval1.9.1? → approval1.9.1+
Target Milestone: --- → Firefox 3.1b3
Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090122 Shiretoko/3.1b3pre
and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090122 Minefield/3.2a1pre
Status: RESOLVED → VERIFIED
This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.

customize toolbar interface is a secondary UI, assuming the icon difference was obvious.
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual][polish-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: