Closed
Bug 424363
Opened 16 years ago
Closed 16 years ago
Customize Toolbar ▸ Restore Default Set uses gtk-refresh instead of gtk-revert-to-saved
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3.1b3
People
(Reporter: adelfino, Assigned: Dolske)
References
Details
(Keywords: polish, verified1.9.1, Whiteboard: [polish-easy] [polish-visual][polish-p2])
Attachments
(2 files, 1 obsolete file)
2.81 KB,
patch
|
Gavin
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
21.66 KB,
image/png
|
faaborg
:
ui-review+
|
Details |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032107 Minefield/3.0b5pre Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032107 Minefield/3.0b5pre Since we are not refreshing anything, but reverting changes gtk-undo should be used. Reproducible: Always
Reporter | ||
Comment 1•16 years ago
|
||
Reporter | ||
Updated•16 years ago
|
Version: unspecified → Trunk
Reporter | ||
Updated•16 years ago
|
Summary: Customize Toolbar > Restore Default Set uses gtk-refresh instead of gtk-undo → Customize Toolbar ▸ Restore Default Set uses gtk-refresh instead of gtk-undo
Comment 2•16 years ago
|
||
If anything, use gtk-revert-to-saved. The icon gtk-undo is for undoing one step, which is not the case here. So, gtk-revert-to-saved or no icon.
Reporter | ||
Comment 3•16 years ago
|
||
(In reply to comment #2) > If anything, use gtk-revert-to-saved. The icon gtk-undo is for undoing one > step, which is not the case here. So, gtk-revert-to-saved or no icon. > You're absolutely right; actually, I was going to morph this bug. I think the gtk-revert-to-saved works fine here.
Summary: Customize Toolbar ▸ Restore Default Set uses gtk-refresh instead of gtk-undo → Customize Toolbar ▸ Restore Default Set uses gtk-refresh instead of gtk-revert-to-saved
Updated•16 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Updated•16 years ago
|
OS: All → Linux
Assignee | ||
Comment 4•16 years ago
|
||
Assignee: nobody → dolske
Attachment #310989 -
Attachment is obsolete: true
Attachment #350557 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 5•16 years ago
|
||
Attachment #350558 -
Flags: ui-review?(faaborg)
Assignee | ||
Comment 6•16 years ago
|
||
(New icon is the top in the screenshot, old icon is the bottom). The change to customizeToolbarSheet.xul probably isn't needed (seems to be mac only), but I figured I'd just keep them more or less in sync.
Updated•16 years ago
|
Attachment #350557 -
Flags: review?(gavin.sharp) → review+
Comment 7•16 years ago
|
||
Comment on attachment 350557 [details] [diff] [review] Patch v.1 >diff --git a/toolkit/content/customizeToolbar.xul b/toolkit/content/customizeToolbar.xul >+ <button label="&restoreDefaultSet.label;" oncommand="restoreDefaultSet();" >+icon="revert"/> What's with the odd indent?
Comment 8•16 years ago
|
||
Comment on attachment 350558 [details]
Screenshot (patch v.1)
I'm assuming these are the correct icons. I actually don't know what gtk-revert-to-saved looks like.
Attachment #350558 -
Flags: ui-review?(faaborg) → ui-review+
Assignee | ||
Updated•16 years ago
|
Attachment #350557 -
Flags: approval1.9.1?
Assignee | ||
Comment 9•16 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/f03bb4a3ce53
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 10•16 years ago
|
||
Comment on attachment 350557 [details] [diff] [review] Patch v.1 a191=beltzner
Attachment #350557 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 11•16 years ago
|
||
Pushed to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a511a6815305
Keywords: fixed1.9.1
Updated•16 years ago
|
Target Milestone: --- → Firefox 3.1b3
Comment 12•15 years ago
|
||
Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090122 Shiretoko/3.1b3pre and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090122 Minefield/3.2a1pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Comment 13•15 years ago
|
||
This bug's priority relative to the set of other polish bugs is: P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable. customize toolbar interface is a secondary UI, assuming the icon difference was obvious.
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual][polish-p2]
You need to log in
before you can comment on or make changes to this bug.
Description
•