424613 - Remove browser/themes/*stripe/browser/bookmarks

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Reed Loden [:reed]]

browser/themes/winstripe/browser/bookmarks and browser/themes/pinstripe/browser/bookmarks aren't needed anymore. They haven't been used since we swapped to places. gnomestripe doesn't even have a bookmarks folder.

Comment 1

[Reed Loden [:reed]]

Really don't have time to look into this... can somebody take this?

Comment 2

[Phil Ringnalda (:philor)]

How on earth could we want to get rid of fun things like "Bookmarks-toolbar.png is only referenced in bookmarksManager.css, and bookmarksManager.css isn't applied to anything, or even jarred up, but wait, Bookmarks-toolbar.png isn't jarred with that name, it's jarred as organizer-toolbar.png, which isn't used anywhere"?

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Surprisingly unexciting, for all that: the stuff that wasn't being jarred is just chaff, organizer-toolbar.png isn't used, and the four pinstripe expander images don't have interesting enough history to be worth CVS moves, so I just copied them over to ../places/.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 316167 [details] [diff] [review]
Fix v.1

a1.9=beltzner

Comment 5

[Phil Ringnalda (:philor)]

browser/themes/pinstripe/browser/jar.mn 1.82
browser/themes/pinstripe/browser/bookmarks/Bookmarks-toolbar.png delete
browser/themes/pinstripe/browser/bookmarks/addBookmark.css delete
browser/themes/pinstripe/browser/bookmarks/bookmark-folder.png delete
browser/themes/pinstripe/browser/bookmarks/bookmark-item.png delete
browser/themes/pinstripe/browser/bookmarks/bookmarksManager.css delete
browser/themes/pinstripe/browser/bookmarks/bookmarksProperties.css delete
browser/themes/pinstripe/browser/bookmarks/expander-closed-active.png delete
browser/themes/pinstripe/browser/bookmarks/expander-closed.png delete
browser/themes/pinstripe/browser/bookmarks/expander-open-active.png delete
browser/themes/pinstripe/browser/bookmarks/expander-open.png delete
browser/themes/pinstripe/browser/bookmarks/folderarrow-hover.png delete
browser/themes/pinstripe/browser/bookmarks/folderarrow.png delete
browser/themes/pinstripe/browser/bookmarks/livemark-folder-hover.png delete
browser/themes/pinstripe/browser/bookmarks/livemark-folder.png delete
browser/themes/pinstripe/browser/bookmarks/livemark-item.png delete
browser/themes/pinstripe/browser/places/expander-closed-active.png 1.1
browser/themes/pinstripe/browser/places/expander-closed.png 1.1
browser/themes/pinstripe/browser/places/expander-open-active.png 1.1
browser/themes/pinstripe/browser/places/expander-open.png 1.1
browser/themes/winstripe/browser/jar.mn 1.89
browser/themes/winstripe/browser/bookmarks/Bookmarks-toolbar.png delete
browser/themes/winstripe/browser/bookmarks/addBookmark.css delete
browser/themes/winstripe/browser/bookmarks/bookmarksManager.css delete
browser/themes/winstripe/browser/bookmarks/bookmarksProperties.css delete