Closed
Bug 424644
Opened 16 years ago
Closed 16 years ago
button for default action ("Restart Firefox") should be on the left
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b1
People
(Reporter: zeniko, Assigned: zeniko)
Details
(Keywords: polish)
Attachments
(1 file, 1 obsolete file)
|
5.51 KB,
patch
|
Details | Diff | Splinter Review |
The current button order is appropriate for OS X and GNOME but not for Windows where the default action (usually OK) is listed before the secondary one (usually Cancel).
|
Assignee | |
Comment 1•16 years ago
|
||
Ted: Would this patch have to go upstream or is the crash reporter client actually our own?
Attachment #335765 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•16 years ago
|
||
The crash reporter client is ours.
|
||
Updated•16 years ago
|
Attachment #335765 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 335765 [details] [diff] [review] swap restart and quit button r=me, but could you not swap lines of code around where it's not really necessary? I don't think the code needs to be in the exact order of the buttons with these two buttons.
|
|
Assignee | |
Comment 4•16 years ago
|
||
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 5•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3f60106dd21a
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
|
||
Comment 6•16 years ago
|
||
verified fixed using : Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081014 Minefield/3.1b2pre.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•